Bump charts to add AuthPolicy #7356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sayanh
force-pushed
the
bump-charts-for-auth-policy
branch
3 times, most recently
from
4418931
to
1f4e1b7
Compare
|
🥰 Documentation preview ready! 🥰 Built with commit 4418931 https://deploy-preview-7356--kyma-project-docs-preview.netlify.com |
sayanh
force-pushed
the
bump-charts-for-auth-policy
branch
from
1f4e1b7
to
2f82c18
Compare
sayanh
force-pushed
the
bump-charts-for-auth-policy
branch
from
31f3ea6
to
25cce01
Compare
k15r
reviewed
Mar 5, 2020
| @@ -7,8 +7,6 @@ metadata: | |||
| {{ toYaml .Values.knative_serving.podmonitor.labels | indent 4 }} | |||
| spec: | |||
| podMetricsEndpoints: | |||
| - port: queue-metrics | |||
| interval: 3s | |||
There was a problem hiding this comment.
how is this related to the image bump?
There was a problem hiding this comment.
Once https://github.com/kyma-project/kyma/pull/7349/files is merged, prometheus will not be able to scrape the port queue-metrics. Additionally, it should not be scraped by Prometheus as per this comment.
|
/retest |
1 similar comment
|
/retest |
…s-for-auth-policy � Conflicts: � resources/application-connector/charts/application-operator/templates/controller.yaml � resources/application-connector/values.yaml
|
/test |
|
/retest |
…s-for-auth-policy
…s-for-auth-policy Conflicts: resources/application-connector/values.yaml
sayanh
requested review from
devguyio,
aerfio,
akgalwas,
anishj0shi,
antoineco,
crabtree,
franpog859 and
janmedrek
as code owners
sayanh
requested review from
joek,
lilitgh,
m00g3n,
magicmatatjahu,
Maladie,
marcobebway,
hudymi,
montaro and
nachtmaar
as code owners
k15r
approved these changes
Mar 18, 2020
Szymongib
reviewed
Mar 18, 2020
| @@ -20,7 +20,8 @@ global: | |||
| path: eu.gcr.io/kyma-project | |||
| application_operator: | |||
| dir: | |||
| version: a6ce3a2c | |||
| version: 39d1ab87 | |||
| strict_mode: disabled | |||
There was a problem hiding this comment.
Can we move it to the application-operator sub chart?
antoineco
approved these changes
Mar 18, 2020
Szymongib
approved these changes
Mar 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
See #7240