Restrict access to Rafter, Tekton and Knative Serving resources #7461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hudymi
added
area/serverless
hudymi
requested review from
Demonsthere,
jakkab,
kubadz,
piotrmsc,
strekm and
Tomasz-Smelcerz-SAP
as code owners
|
🥰 Documentation preview ready! 🥰 Built with commit cba1ce2 https://deploy-preview-7461--kyma-project-docs-preview.netlify.com |
hudymi
added
the
security/medium
piotrmsc
reviewed
Mar 5, 2020
| @@ -232,6 +309,8 @@ function runTests() { | |||
| echo "--> ${ADMIN_EMAIL} should be able to patch Installation CR in ${NAMESPACE}" | |||
| testPermissions "patch" "installation" "${NAMESPACE}" "yes" | |||
|
|
|||
There was a problem hiding this comment.
TBH this testRafter function should also contain expected authZ result because IMO admin should have access to CRUD operations on rafter resources. Currently, it's hardcoded for all type of users
There was a problem hiding this comment.
We want to prevent the creation/update/deletion of any resources by all type of users. Only person who has access to kubeconfig from cluster can create resources.
piotrmsc
approved these changes
Mar 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)