Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inject serviceBindings labels in Function CR - integration #8343

Merged
merged 12 commits into from May 10, 2020
Merged

Inject serviceBindings labels in Function CR - integration #8343

merged 12 commits into from May 10, 2020

Conversation

magicmatatjahu
Copy link
Contributor

@magicmatatjahu magicmatatjahu commented May 3, 2020 •
edited

Description

Changes proposed in this pull request:

  • Update appropriate charts
  • Prepare migration job for changing knative-service to function UsageKind related to Function CR
  • Remove kubeless UsageKind CR
  • Update CBS, CoreUI, Serverless tests images with changing knative-service to function UsageKind
  • Update docs

Related issue(s)
#8203

@magicmatatjahu magicmatatjahu requested a review from a user May 3, 2020 14:58
@netlify
Copy link

netlify bot commented May 3, 2020 •
edited

🥰 Documentation preview ready! 🥰

Built with commit 5565216

https://deploy-preview-8343--kyma-project-docs-preview.netlify.app

@magicmatatjahu
Copy link
Contributor Author

/test pre-master-kyma-gke-integration
/test pre-master-kyma-gke-upgrade

magicmatatjahu
magicmatatjahu commented May 6, 2020
View reviewed changes
resources/serverless/values.yaml Outdated
@@ -4,6 +4,12 @@

fullnameOverride: "serverless"

bindingsMigration:
image:
repository: 'dtzar/helm-kubectl'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the images I was looking for have only kubectl, and this has also apk, shell etc. what is needed in migration job.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a look at https://github.com/kyma-project/kyma/blob/master/resources/rafter/values.yaml#L331

it has kubectl, helm, jq etc, I think everything that you need, and it's "blessed" by our testinfra team -> no security issues with it

aerfio
aerfio suggested changes May 6, 2020
View reviewed changes
resources/serverless/values.yaml Outdated
@@ -4,6 +4,12 @@

fullnameOverride: "serverless"

bindingsMigration:
image:
repository: 'dtzar/helm-kubectl'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have a look at https://github.com/kyma-project/kyma/blob/master/resources/rafter/values.yaml#L331

it has kubectl, helm, jq etc, I think everything that you need, and it's "blessed" by our testinfra team -> no security issues with it

...s/service-catalog-addons/charts/service-binding-usage-controller/templates/cluster-role.yaml Show resolved Hide resolved
resources/serverless/templates/_helper_bindings_migration.txt Outdated Show resolved Hide resolved
@aerfio
Copy link
Contributor

aerfio commented May 6, 2020

/retest

@magicmatatjahu magicmatatjahu requested a review from a team as a code owner May 6, 2020 20:33
@hudymi hudymi linked an issue May 6, 2020 that may be closed by this pull request
Injecting pod labels in Function CR #8203
Closed
@magicmatatjahu magicmatatjahu force-pushed the serverless-ctrl-pod-labels-integration branch from 5348245 to 3af22bd Compare May 7, 2020 06:12
@magicmatatjahu
Copy link
Contributor Author

/test pre-master-kyma-gke-integration

@hudymi hudymi added area/documentation Issues or PRs related to documentation area/serverless Issues or PRs related to serverless labels May 7, 2020
@magicmatatjahu
Copy link
Contributor Author

/test all

@magicmatatjahu
Copy link
Contributor Author

/test pre-master-kyma-gke-upgrade

@magicmatatjahu
Copy link
Contributor Author

/test pre-master-kyma-gke-upgrade

1 similar comment
@magicmatatjahu
Copy link
Contributor Author

/test pre-master-kyma-gke-upgrade

@magicmatatjahu
Copy link
Contributor Author

/test all

@magicmatatjahu magicmatatjahu merged commit 19aec6f into kyma-project:master May 10, 2020
@magicmatatjahu magicmatatjahu deleted the serverless-ctrl-pod-labels-integration branch May 10, 2020 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aerfio aerfio aerfio approved these changes

@akucharska akucharska akucharska approved these changes

@polskikiel polskikiel polskikiel approved these changes

@hudymi hudymi hudymi approved these changes

@kazydek kazydek kazydek approved these changes

@devguyio devguyio Awaiting requested review from devguyio

@adamwalach adamwalach Awaiting requested review from adamwalach

@anishj0shi anishj0shi Awaiting requested review from anishj0shi

@jasiu001 jasiu001 Awaiting requested review from jasiu001

@k15r k15r Awaiting requested review from k15r

@ksputo ksputo Awaiting requested review from ksputo

@lilitgh lilitgh Awaiting requested review from lilitgh

@m00g3n m00g3n Awaiting requested review from m00g3n

@marcobebway marcobebway Awaiting requested review from marcobebway

@montaro montaro Awaiting requested review from montaro

@mszostok mszostok Awaiting requested review from mszostok

@nachtmaar nachtmaar Awaiting requested review from nachtmaar

@piotrmiskiewicz piotrmiskiewicz Awaiting requested review from piotrmiskiewicz

@PK85 PK85 Awaiting requested review from PK85

@pPrecel pPrecel Awaiting requested review from pPrecel

@sayanh sayanh Awaiting requested review from sayanh

@janmedrek janmedrek Awaiting requested review from janmedrek

@piotrmsc piotrmsc Awaiting requested review from piotrmsc

@alexandra-simeonova alexandra-simeonova Awaiting requested review from alexandra-simeonova

@bszwarc bszwarc Awaiting requested review from bszwarc

@dariadomagala-sap dariadomagala-sap Awaiting requested review from dariadomagala-sap

@klaudiagrz klaudiagrz Awaiting requested review from klaudiagrz

@kwiatekus kwiatekus Awaiting requested review from kwiatekus

@majakurcius majakurcius Awaiting requested review from majakurcius

@mmitoraj mmitoraj Awaiting requested review from mmitoraj

@parostatkiem-zz parostatkiem-zz Awaiting requested review from parostatkiem-zz

@tomekpapiernik tomekpapiernik Awaiting requested review from tomekpapiernik

@Wawrzyn321 Wawrzyn321 Awaiting requested review from Wawrzyn321

Assignees

@aerfio aerfio

Labels
area/documentation Issues or PRs related to documentation area/serverless Issues or PRs related to serverless
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Injecting pod labels in Function CR
6 participants
@magicmatatjahu @aerfio @akucharska @polskikiel @hudymi @kazydek