Move ory crds to cluster essentials #8370
Conversation
m00g3n
requested review from
Demonsthere,
jakkab,
janmedrek,
kubadz,
hudymi,
piotrmsc,
PK85,
strekm and
Tomasz-Smelcerz-SAP
as code owners
|
🥰 Documentation preview ready! 🥰 Built with commit 6d15ff2 https://deploy-preview-8370--kyma-project-docs-preview.netlify.app |
|
/test pre-master-kyma-gke-upgrade |
|
/test pre-master-kyma-gke-upgrade |
|
/test pre-master-kyma-gke-compass-integration |
|
/test pre-master-kyma-gke-integration |
|
/test pre-master-kyma-gke-compass-integration |
m00g3n
added
area/cluster
| - /bin/bash | ||
| - -c | ||
| - |- | ||
| set -e |
There was a problem hiding this comment.
In general we should consider retries for all kubectl operations in jobs. Cool example can be found here with timeout & until https://github.com/kyma-project/kyma/blob/master/installation/resources/tiller.yaml#L129
crafted by our bash hero @Demonsthere
|
/test pre-master-kyma-gke-compass-integration |
| @@ -22,9 +22,31 @@ spec: | |||
| - name: crd-oauth2clients | |||
| mountPath: /etc/crd | |||
| readOnly: true | |||
| command: ["kubectl", "apply", "-f", "/etc/crd/oauth2clients.yaml"] | |||
| command: | |||
| - timeout | |||
There was a problem hiding this comment.
Since we are doing bash in bash here, maybe to simplify this structure a little bit, move it to a separate file in the files directory, and include it with Files.Get? The current form is very hard to read
There was a problem hiding this comment.
Good point. I think the best idea would be to do it in a follow-up task that we could start to work on once we will have all CRDs in cluster-essentials. We could also come up with some generic mechanism (e.g. base on directory structure) that would have a logic to install/update all the CRDs .
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Please also update README of CE repo https://github.com/kyma-project/kyma/tree/master/resources/cluster-essentials. With all your pr's moving CRDs we need to properly describe what is now |
Description
Changes proposed in this pull request:
Related issue(s)
See also: #7933