Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt pod preset webhook to gardener system #8767

Merged
merged 1 commit into from Jun 15, 2020

Conversation

jasiu001
Copy link

Description

Changes proposed in this pull request:

  • change of the default timeout for MutatingWebhookConfiguration in version admissionregistration.k8s.io/v1beta1 from 30sec to 10sec
  • add namespaceSelector to MutatingWebhookConfiguration to exclude resources from kube-system namespace on Gardner system (on Gardner namespace resource gets gardener.cloud/purpose: kube-sytem flag)
  • add PodDisruptionBudget to webhook Pod with minAvailable set to 1, to provide at least one Pod webhook in running condition.

@jasiu001 jasiu001 added the area/service-management Issues or PRs related to service management label Jun 10, 2020
@netlify
Copy link

netlify bot commented Jun 10, 2020

🥰 Documentation preview ready! 🥰

Built with commit 0d0965d

https://deploy-preview-8767--kyma-project-docs-preview.netlify.app

@jasiu001
Copy link
Author

/test pre-master-kyma-gke-upgrade

@kyma-bot
Copy link
Contributor

kyma-bot commented Jun 10, 2020

@jasiu001: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pre-master-kyma-gke-upgrade-e2e 0d0965d link /test pre-master-kyma-gke-upgrade-e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jasiu001
Copy link
Author

/test pre-master-kyma-gke-compass-integration

@polskikiel polskikiel self-assigned this Jun 10, 2020
Copy link
Contributor

@polskikiel polskikiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jasiu001 jasiu001 merged commit 0188520 into kyma-project:master Jun 15, 2020
@jasiu001 jasiu001 deleted the pod-preset-webhook-fix branch October 13, 2020 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/service-management Issues or PRs related to service management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants