Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies in Application Connector components #9349

Merged
merged 11 commits into from Sep 3, 2020
Merged

Update dependencies in Application Connector components #9349

merged 11 commits into from Sep 3, 2020

Conversation

Szymongib
Copy link
Contributor

Description

Changes proposed in this pull request:

  • Update dependencies in:
    • Application Connectivity Validator
    • Application Registry
    • Application Gateway
    • Application Gateway Tests

Related issue(s)

@netlify
Copy link

netlify bot commented Sep 2, 2020 •
edited

🥰 Documentation preview ready! 🥰

Built with commit 6029536

https://deploy-preview-9349--kyma-project-docs-preview.netlify.app

@Szymongib Szymongib marked this pull request as ready for review September 2, 2020 12:25
@Szymongib Szymongib added the area/application-connector Issues or PRs related to application connectivity label Sep 2, 2020
rafalpotempa
rafalpotempa previously approved these changes Sep 2, 2020
View reviewed changes
tests/application-gateway-tests/go.mod
)

replace github.com/kyma-project/kyma/components/application-gateway => github.com/Szymongib/kyma/components/application-gateway v0.0.0-20200902080656-573e032dd983
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's an artifact

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is needed as master version of Gateway uses an older version of the Application Operator, which actually uses the old version of the service-catalog client.

@rafalpotempa
Copy link
Contributor

/test pre-master-kyma-gke-central-connector

majakurcius
majakurcius previously approved these changes Sep 3, 2020
View reviewed changes
Copy link
Contributor

@majakurcius majakurcius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

majakurcius
majakurcius approved these changes Sep 3, 2020
View reviewed changes
Copy link
Contributor

@majakurcius majakurcius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@Szymongib
Copy link
Contributor Author

/retest

@Szymongib
Copy link
Contributor Author

/test pre-master-kyma-gke-upgrade

@majakurcius
Copy link
Contributor

/test pre-master-kyma-gardener-azure-integration

@Szymongib Szymongib merged commit 0fae372 into kyma-project:master Sep 3, 2020
@kyma-bot
Copy link
Contributor

kyma-bot commented Sep 3, 2020

@Szymongib: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pre-master-kyma-gardener-azure-integration 6029536 link /test pre-master-kyma-gardener-azure-integration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafalpotempa rafalpotempa rafalpotempa approved these changes

@majakurcius majakurcius majakurcius approved these changes

@akgalwas akgalwas Awaiting requested review from akgalwas

@crabtree crabtree Awaiting requested review from crabtree

@franpog859 franpog859 Awaiting requested review from franpog859

@janmedrek janmedrek Awaiting requested review from janmedrek

@Maladie Maladie Awaiting requested review from Maladie

@alexandra-simeonova alexandra-simeonova Awaiting requested review from alexandra-simeonova

@bszwarc bszwarc Awaiting requested review from bszwarc

@kazydek kazydek Awaiting requested review from kazydek

@klaudiagrz klaudiagrz Awaiting requested review from klaudiagrz

@mmitoraj mmitoraj Awaiting requested review from mmitoraj

Assignees
No one assigned
Labels
area/application-connector Issues or PRs related to application connectivity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Szymongib @rafalpotempa @majakurcius @kyma-bot