Proper aggregation of istio metrics using prometheus federation #9700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakesh-garimella
requested review from
a-thaler,
aerfio,
anishj0shi,
clebs,
Demonsthere,
hisarbalik,
jakkab,
k15r,
kubadz,
lilitgh,
m00g3n,
magicmatatjahu,
marcobebway,
montaro,
nachtmaar,
piotrmsc and
pPrecel
as code owners
rakesh-garimella
requested review from
sayanh,
strekm,
suleymanakbas91 and
Tomasz-Smelcerz-SAP
as code owners
hisarbalik
previously approved these changes
Oct 14, 2020
|
/retest |
hisarbalik
added
the
area/monitoring
a-thaler
force-pushed
the
increase-scrape-interval
branch
from
bf45a27
to
3ee8540
Compare
rakesh-garimella
requested review from
adamwalach and
crabtree
as code owners
rakesh-garimella
requested review from
alexandra-simeonova,
bszwarc,
kazydek,
klaudiagrz,
majakurcius and
mmitoraj
as code owners
a-thaler
changed the title
a-thaler
previously approved these changes
Oct 18, 2020
a-thaler
previously approved these changes
Oct 19, 2020
piotrmsc
previously approved these changes
Oct 19, 2020
a-thaler
previously approved these changes
Oct 19, 2020
klaudiagrz
reviewed
Oct 19, 2020
Co-authored-by: Klaudia Grzondziel <35192450+klaudiagrz@users.noreply.github.com>
a-thaler
approved these changes
Oct 19, 2020
klaudiagrz
approved these changes
Oct 19, 2020
piotrmsc
approved these changes
Oct 19, 2020
m00g3n
approved these changes
Oct 19, 2020
|
/retest |
hisarbalik
approved these changes
Oct 19, 2020
dbadura
pushed a commit
to dbadura/kyma
that referenced
this pull request
Oct 19, 2020
…-project#9700) * switch to federation for istio metrics by adding a second prometheus
dbadura
pushed a commit
that referenced
this pull request
Oct 29, 2020
* switch to federation for istio metrics by adding a second prometheus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes proposed in this pull request:
Related issue(s)
Fixes: #9701