Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: helm reference #14

Merged
merged 8 commits into from
Jan 30, 2023
Merged

feat: helm reference #14

merged 8 commits into from
Jan 30, 2023

Conversation

adityabhatia
Copy link
Contributor

@adityabhatia adityabhatia commented Jan 20, 2023 •
edited
Loading

Description

Changes proposed in this pull request:

  • Provide a Helm-based exemplary operator
  • Update documentation for API reference and controller implementation

Related issue(s)

@adityabhatia adityabhatia marked this pull request as draft January 20, 2023 16:04
@kyma-bot kyma-bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Jan 20, 2023
@kyma-bot kyma-bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jan 23, 2023
@adityabhatia adityabhatia marked this pull request as ready for review January 24, 2023 11:29
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 24, 2023
@adityabhatia adityabhatia linked an issue Jan 24, 2023 that may be closed by this pull request
Provide a Helm-based example for an operator #11
Closed
3 tasks
lindnerby
lindnerby previously approved these changes Jan 27, 2023
View reviewed changes
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 27, 2023
@lindnerby lindnerby removed their assignment Jan 27, 2023
@Tomasz-Smelcerz-SAP
Copy link
Member

make install doesn't work for me:

~/Documents/development/golang/src/github.com/kyma-project/template-operator/bin/controller-gen rbac:roleName=manager-role crd webhook paths="./..." output:crd:artifacts:config=config/crd/bases
~/Documents/development/golang/src/github.com/kyma-project/template-operator/bin/kustomize build config/crd | kubectl apply -f -
Error: error converting YAML to JSON: yaml: line 8: did not find expected key
error: no objects passed to apply
make: *** [Makefile:82: install] Error 1

Tomasz-Smelcerz-SAP
Tomasz-Smelcerz-SAP requested changes Jan 27, 2023
View reviewed changes
Copy link
Member

@Tomasz-Smelcerz-SAP Tomasz-Smelcerz-SAP left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something is misconfigured in the kustomization.
In addition, there's no EventRecorder attached to the new SampleHelmReconciler which causes panics in runtime.

@kyma-bot kyma-bot removed the lgtm Looks good to me! label Jan 27, 2023
Tomasz-Smelcerz-SAP
Tomasz-Smelcerz-SAP reviewed Jan 27, 2023
View reviewed changes
main.go Outdated Show resolved Hide resolved
Tomasz-Smelcerz-SAP
Tomasz-Smelcerz-SAP reviewed Jan 30, 2023
View reviewed changes
config/samples/operator.kyma-project.io_v1alpha1_samplehelm.yaml Outdated
@@ -0,0 +1,12 @@
apiVersion: operator.kyma-project.io.kyma-project.io/v1alpha1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicated kyma-project.io

@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 30, 2023
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Jan 30, 2023
@kyma-bot kyma-bot added the lgtm Looks good to me! label Jan 30, 2023
@kyma-bot kyma-bot merged commit 7ce85e0 into kyma-project:main Jan 30, 2023
@adityabhatia adityabhatia mentioned this pull request Jan 31, 2023
Merged
@Tomasz-Smelcerz-SAP Tomasz-Smelcerz-SAP mentioned this pull request Feb 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tomasz-Smelcerz-SAP Tomasz-Smelcerz-SAP Tomasz-Smelcerz-SAP approved these changes

@lindnerby lindnerby lindnerby left review comments

@fourthisle fourthisle Awaiting requested review from fourthisle

@jeremyharisch jeremyharisch Awaiting requested review from jeremyharisch

@ruanxin ruanxin Awaiting requested review from ruanxin

@tobiscr tobiscr Awaiting requested review from tobiscr

@clebs clebs Awaiting requested review from clebs

@jakobmoellerdev jakobmoellerdev Awaiting requested review from jakobmoellerdev

@janmedrek janmedrek Awaiting requested review from janmedrek

Assignees

@Tomasz-Smelcerz-SAP Tomasz-Smelcerz-SAP

Labels
lgtm Looks good to me! size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide a Helm-based example for an operator
4 participants
@adityabhatia @Tomasz-Smelcerz-SAP @lindnerby @kyma-bot