Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify labels #57

Merged
merged 3 commits into from
Feb 10, 2023
Merged

Unify labels #57

merged 3 commits into from
Feb 10, 2023

Conversation

dbadura
Copy link
Contributor

@dbadura dbadura commented Feb 8, 2023 •
edited
Loading

Unify labels to have:

  • ability to get logs from admission and operator by label: kubectl logs -l app=warden --prefix=true
  • distinguish between operator and admission
  • The version 0.0.6 is upgradable to this version

See: #42

@kyma-bot kyma-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 8, 2023
@kyma-bot
Copy link
Contributor

kyma-bot commented Feb 8, 2023

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kyma-bot kyma-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 8, 2023
@dbadura dbadura marked this pull request as ready for review February 9, 2023 09:15
@kyma-bot kyma-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 9, 2023
m00g3n
m00g3n approved these changes Feb 10, 2023
View reviewed changes
Copy link
Contributor

@m00g3n m00g3n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kyma-bot kyma-bot added the lgtm Looks good to me! label Feb 10, 2023
@kyma-bot kyma-bot merged commit 18d52ad into kyma-project:main Feb 10, 2023
@dbadura dbadura deleted the unify-labels branch February 10, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m00g3n m00g3n m00g3n approved these changes

@anoipm anoipm Awaiting requested review from anoipm anoipm is a code owner

@pPrecel pPrecel Awaiting requested review from pPrecel pPrecel is a code owner

@kwiatekus kwiatekus Awaiting requested review from kwiatekus kwiatekus is a code owner

@Cortey Cortey Awaiting requested review from Cortey Cortey is a code owner

Assignees

@m00g3n m00g3n

Labels
lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dbadura @kyma-bot @m00g3n