New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test 1d #623
Test 1d #623
Conversation
we should really finish up the R2C pr first tho. |
Codecov Report
@@ Coverage Diff @@
## dev #623 +/- ##
==========================================
- Coverage 88.35% 79.05% -9.31%
==========================================
Files 64 64
Lines 2319 2320 +1
==========================================
- Hits 2049 1834 -215
- Misses 270 486 +216
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
are we ready for merge? |
assert 'should be complex' in record.value.args[0] | ||
|
||
def test_fft(): | ||
x = torch.randn(2, 1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just add that blank line and it's ready for merge.
Added! |
yup seems good to go to me |
Added one more padding test
Let's make sure the tests pass, then we're ready to merge. |
The tests pass on my end. I can try changing the tolerance and see if that changes things |
Looks like jenkins passes. |
Still failing on Travis. Can you increase the tolerance for that test? Also make sure to put a comment explaining why we need the increased tolerances. |
This PR adds a whole suite of tests for the Torch, Tensorflow, and Numpy backend primitives. Additionally, tests for scattering and tests for backend primitives are broken into two separate files. Perhaps we want to do something similar with frontend tests?
Additionally, some already existing backend functions have been modified to perform type checking, such as adding a complex check to the subsampling functions in the numpy and tensorflow backends.