Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate self.N in 2D #886

Merged
merged 4 commits into from Jun 18, 2022
Merged

Deprecate self.N in 2D #886

merged 4 commits into from Jun 18, 2022

Conversation

lostanlen
Copy link
Collaborator

2D equivalent of #863
triaged for v0.3

@lostanlen lostanlen added the 2D Issue with 2D scattering code label Jun 15, 2022
MuawizChaudhary
MuawizChaudhary approved these changes Jun 16, 2022
View reviewed changes
Copy link
Collaborator

@MuawizChaudhary MuawizChaudhary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this.

@lostanlen lostanlen changed the title Deprecate self.N in 2D Deprecate self.N in 2D Jun 16, 2022
@lostanlen lostanlen requested a review from janden June 16, 2022 20:34
@lostanlen
Copy link
Collaborator Author

@janden merge at your convenience

@MuawizChaudhary
Copy link
Collaborator

MuawizChaudhary commented Jun 16, 2022 •
edited

I think in this instance its worth it having a deprecation warning. EDIT: tho, personally, I am fine with changing up the code here as I'm sure we're likely the only people to access this variable...

cyrusvahidi
cyrusvahidi approved these changes Jun 17, 2022
View reviewed changes
Copy link
Collaborator

@cyrusvahidi cyrusvahidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good

@MuawizChaudhary MuawizChaudhary merged commit e89ec79 into kymatio:dev Jun 18, 2022
@lostanlen lostanlen mentioned this pull request Jun 18, 2022
Closed
@lostanlen lostanlen deleted the deprecate-N-2D-3D branch June 25, 2022 16:22
eickenberg pushed a commit that referenced this pull request Jul 5, 2022
@lostanlen @eickenberg
Deprecate self.N in 2D (#886)
135158a 
* update 2D base frontend

* deprecate N in 2D

* bugfix

* set M and N as @Property in Sc2D
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cyrusvahidi cyrusvahidi cyrusvahidi approved these changes

@MuawizChaudhary MuawizChaudhary MuawizChaudhary approved these changes

@janden janden Awaiting requested review from janden

Assignees
No one assigned
Labels
2D Issue with 2D scattering code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lostanlen @MuawizChaudhary @cyrusvahidi