Merged
Conversation
MuawizChaudhary
approved these changes
Jun 16, 2022
Collaborator
MuawizChaudhary
left a comment
MuawizChaudhary
left a comment
There was a problem hiding this comment.
Thanks for this.
Collaborator
Author
|
@janden merge at your convenience |
MuawizChaudhary
requested changes
Jun 16, 2022
Collaborator
|
I think in this instance its worth it having a deprecation warning. EDIT: tho, personally, I am fine with changing up the code here as I'm sure we're likely the only people to access this variable... |
cyrusasfa
reviewed
Jun 17, 2022
MuawizChaudhary
approved these changes
Jun 18, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2D equivalent of #863
triaged for v0.3