Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

--dry-run should exit non-0 if files would be updated #159

Closed
joaonc opened this issue Oct 29, 2021 · 1 comment
Closed

--dry-run should exit non-0 if files would be updated #159

joaonc opened this issue Oct 29, 2021 · 1 comment
Labels
resolution:duplicate type:enhancement

Comments

@joaonc
Copy link

joaonc commented Oct 29, 2021

Using nbstripout as a pre-commit hook with the --dry-run option so the verification fails with a list of files that need to be updated without actually updating the files. But --dry-run always exits with 0 (success), which means the hook doesn't work with --dry-run.

IMO, --dry-run should return non-0 (ideally 1) if any file would be changed by running nbstripout.
@joaonc joaonc mentioned this issue Oct 30, 2021
Open
@joaonc
Copy link
Author

joaonc commented Oct 30, 2021

Oh, this is a dup of #153

Closing.

@joaonc joaonc closed this as completed Oct 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
resolution:duplicate type:enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kynan @joaonc