Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to keep output style #78

Closed
melsophos opened this issue Apr 24, 2018 · 7 comments · Fixed by #177
Closed

Option to keep output style #78

melsophos opened this issue Apr 24, 2018 · 7 comments · Fixed by #177
Labels
help wanted type:enhancement
Milestone
0.6.2

Comments

@melsophos
Copy link

It would be nice to have an option to keep the way output is displayed (between standard, scrolled, and collapsed) since it is more part of formatting than of outputs (I am enabling scrolling when I know that the output will be large, but when I still want to display it).
@jeremydouglass
Copy link

I agree, this might be a useful option. Perhaps here?

https://github.com/kynan/nbstripout/blob/master/nbstripout.py#L184

@kynan
Copy link
Owner

kynan commented Jul 9, 2018

Agreed, that'd be a welcome addition. Do you feel like working on a pull request @melsophos @jeremydouglass ?

@kynan kynan mentioned this issue Aug 14, 2018
Open
@kynan kynan added this to the Backlog milestone Jun 28, 2020
@kynan
Copy link
Owner

kynan commented Sep 24, 2022

Is this still a use case you have @melsophos @jeremydouglass ?

@melsophos
Copy link
Author

I have not used much notebooks in the last year. As a matter of principle, I think that the option is still useful, but I don't have a strong motivation for it now.
(Also sorry for not replying to your message 4 years ago, I missed it.)

@jeremydouglass
Copy link

@kynan - Unfortunately I haven't been using notebook-based projects much recently, so I don't have an active use case to test this right now.

@davidxia
Copy link
Contributor

@kynan I can work on this since I need it.

davidxia added a commit to davidxia/nbstripout that referenced this issue Nov 25, 2022
@davidxia
feat: add option to keep output style
161019e 
with `nbstripout --keep-metadata-keys` or git config key
`filter.nbstripout.keepmetadatakeys`.

closes kynan#78
@davidxia davidxia mentioned this issue Nov 25, 2022
Merged
@davidxia
Copy link
Contributor

@kynan just made a PR for this in #177. Lmk if you have any questions!

davidxia added a commit to davidxia/nbstripout that referenced this issue Dec 1, 2022
@davidxia
feat: add option to keep output style
4ce4da2 
with `nbstripout --keep-metadata-keys` or git config key
`filter.nbstripout.keepmetadatakeys`.

closes kynan#78
davidxia added a commit to davidxia/nbstripout that referenced this issue Dec 4, 2022
@davidxia
feat: add option to keep output style
3cbe24e 
with `nbstripout --keep-metadata-keys` or git config key
`filter.nbstripout.keepmetadatakeys`.

closes kynan#78
davidxia added a commit to davidxia/nbstripout that referenced this issue Dec 8, 2022
@davidxia
feat: add option to keep output style
13621a8 
with `nbstripout --keep-metadata-keys` or git config key
`filter.nbstripout.keepmetadatakeys`.

closes kynan#78
davidxia added a commit to davidxia/nbstripout that referenced this issue Dec 8, 2022
@davidxia
feat: add option to keep output style
4300c75 
with `nbstripout --keep-metadata-keys` or git config key
`filter.nbstripout.keepmetadatakeys`.

closes kynan#78
@kynan kynan closed this as completed in #177 Dec 9, 2022
kynan pushed a commit that referenced this issue Dec 9, 2022
@davidxia
feat: add option to keep output style (#177)
1185a8d 
with `nbstripout --keep-metadata-keys` or git config key `filter.nbstripout.keepmetadatakeys`.

closes #78
@kynan kynan modified the milestones: Backlog, 0.6.2 Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted type:enhancement
Projects
None yet
Milestone
0.6.2
Development

Successfully merging a pull request may close this issue.

feat: add option to keep output style davidxia/nbstripout
4 participants
@melsophos @kynan @davidxia @jeremydouglass