Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 0.3.4 no longer executable as a module #94

Closed
SimonBiggs opened this issue Mar 27, 2019 · 3 comments
Closed

Version 0.3.4 no longer executable as a module #94

SimonBiggs opened this issue Mar 27, 2019 · 3 comments

Comments

@SimonBiggs
Copy link
Contributor

Hi @kynan,

Thank you so much for your great tool :).

I wanted to bring something to your attention with version 0.3.4. In my CI I have a task that checks to see if any notebooks have been committed with output. After the 0.3.4 release I noted that the following error is now risen by the following command:

find . -iname \*.ipynb | xargs -d "\n" python -m nbstripout && git add -A && git diff HEAD --name-only --exit-code -- "*ipynb"
========================== Starting Command Output ===========================
[command]/bin/bash --noprofile --norc /home/vsts/work/_temp/fdd732e9-0a6c-4132-8741-65ba6510303f.sh
/usr/bin/python: No module named nbstripout.__main__; 'nbstripout' is a package and cannot be directly executed
##[error]Bash exited with code '123'.
##[section]Finishing: Check that notebooks have no included output

Whereas previously this command did the following:

Script contents:
find . -iname \*.ipynb | xargs -d "\n" python -m nbstripout && git add -A && git diff HEAD --name-only --exit-code -- "*ipynb"
========================== Starting Command Output ===========================
[command]/bin/bash --noprofile --norc /home/vsts/work/_temp/18a83b26-ff5e-4daf-8560-26a800c7f026.sh
##[section]Finishing: Check that notebooks have no included output

See version 0.3.3, compared to 0.3.4 in the following:

Personally I'm just going to currently tell tox to use version <= 0.3.3 so no big issue on my end, but just wanted to let you know.

@kynan kynan changed the title Version 0.3.4 has appears to have a backwards incompatibility with 0.3.3 Version 0.3.4 no longer executable as a module Apr 1, 2019
@kynan
Copy link
Owner

kynan commented Apr 1, 2019

Thanks for reporting! This is an unintended side effect from #92. I'll push a fix and tag a new release.

@SimonBiggs
Copy link
Contributor Author

SimonBiggs commented Apr 2, 2019

You're welcome :) thanks for the great tool, and thanks for the fix :)

@kynan kynan closed this as completed in 17c9e95 Apr 2, 2019
@kynan
Copy link
Owner

kynan commented Apr 2, 2019

0.3.5 is released!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants