Deeplink: refactor (#319)

* Fix "Repais bid"

* Improve UX

* PR comments

* Refactor deeplink

Co-authored-by: Chi Kei Chan <chikeichan@gmail.com>

app/deeplink/index.js

@@ -0,0 +1,30 @@
+import { setDeeplink } from '../ducks/app';
+import { clientStub as aClientStub } from '../background/analytics/client';
+const analytics = aClientStub(() => require('electron').ipcRenderer);
+import { store } from '../store/configureStore';
+import * as methods from './methods';
+
+export default function handleDeeplink(message) {
+  const url = new URL(message);
+  const state = store.getState();
+  const isLocked = state.wallet.isLocked;
+
+  analytics.track('deeplink', {
+    pathname: url.pathname,
+  });
+
+  // pathname = "//method/"
+  const [method] = url.pathname.substr(2).split('/');
+  const handler = methods[method];
+
+  if (typeof handler === 'function') {
+    if (isLocked) {
+      store.dispatch(setDeeplink(message));
+      return;
+    }
+
+    methods[method](message);
+  } else {
+    console.error('Unknown deeplink:', message);
+  }
+}

app/deeplink/methods/fulfillauction.js

@@ -0,0 +1,16 @@
+import { history } from '../../store/configureStore';
+
+export default message => {
+  const url = new URL(message);
+  const params = url.searchParams;
+  const name = params.get('name');
+  const presignJSONString = params.get('presign');
+
+  if (presignJSONString) {
+    store.dispatch(setDeeplinkParams({ presignJSONString }));
+  }
+
+  if (name) {
+    history.push(`/exchange`);
+  }
+};

app/deeplink/methods/index.js

@@ -0,0 +1,4 @@
+export { default as fulfillauction } from './fulfillauction';
+export { default as openmanager } from './openmanager';
+export { default as openname } from './openname';
+export { default as updaterecord } from './updaterecord';

app/deeplink/methods/openmanager.js

@@ -0,0 +1,7 @@
+import { history } from '../../store/configureStore';
+
+export default message => {
+  const name = new URL(message).searchParams.get('name');
+
+  history.push(`/domain_manager/${name}`);
+};

app/deeplink/methods/openname.js

@@ -0,0 +1,7 @@
+import { history } from '../../store/configureStore';
+
+export default message => {
+  const name = new URL(message).searchParams.get('name');
+
+  history.push(`/domain/${name}`);
+};

app/deeplink/methods/updaterecord.js

@@ -0,0 +1,14 @@
+import { history, store } from '../../store/configureStore';
+import { setDeeplinkParams } from '../../ducks/app';
+
+export default message => {
+  const url = new URL(message);
+  const params = url.searchParams;
+  const name = params.get('name');
+  const txt = params.get('txt');
+
+  if (txt) {
+    store.dispatch(setDeeplinkParams({ txt }));
+  }
+  history.push(`/domain_manager/${name}`);
+};

app/index.js

@@ -10,8 +10,7 @@ import { history, store } from './store/configureStore';
 import './global.scss';
 import { showError } from './ducks/notifications';
 import {ipcRenderer} from "electron";
-import { clientStub as aClientStub } from './background/analytics/client';
-const analytics = aClientStub(() => require('electron').ipcRenderer);
+import handleDeeplink from './deeplink'
 
 window.addEventListener('error', (e) => {
   store.dispatch(showError(e.message));
@@ -27,73 +26,6 @@ ipcRenderer.on('deeplink', (_, message) => {
   handleDeeplink(message);
 });
 
-function handleDeeplink(message) {
-  const url = new URL(message);
-  const state = store.getState();
-  const isLocked = state.wallet.isLocked;
-  const params = url.searchParams;
-
-  analytics.track('deeplink', {
-    pathname: url.pathname,
-  });
-
-  let name, txt, presignJSONString;
-  switch (url.pathname) {
-    case "//updaterecord":
-    case "//updaterecord/":
-      name = params.get('name');
-      txt = params.get('txt');
-
-      if (txt) {
-        store.dispatch(setDeeplinkParams({ txt }));
-      }
-
-      if (isLocked) {
-        store.dispatch(setDeeplink(message));
-      } else {
-        history.push(`/domain_manager/${name}`);
-      }
-      return;
-    case "//openname":
-    case "//openname/":
-      name = params.get('name');
-
-      if (isLocked) {
-        store.dispatch(setDeeplink(message));
-      } else {
-        history.push(`/domain/${name}`);
-      }
-      return;
-    case "//openmanager":
-    case "//openmanager/":
-      name = params.get('name');
-
-      if (isLocked) {
-        store.dispatch(setDeeplink(message));
-      } else if (name) {
-        history.push(`/domain_manager/${name}`);
-      }
-      return;
-    case "//fulfillauction":
-    case "//fulfillauction/":
-      name = params.get('name');
-      presignJSONString = params.get('presign');
-
-      if (presignJSONString) {
-        store.dispatch(setDeeplinkParams({ presignJSONString }));
-      }
-
-      if (isLocked) {
-        store.dispatch(setDeeplink(message));
-      } else if (name) {
-        history.push(`/exchange`);
-      }
-      return;
-    default:
-      return;
-  }
-}
-
 history.listen(location => {
   const state = store.getState();
   const deeplink = state.app.deeplink;

app/pages/Auction/RepairBid.js

@@ -57,7 +57,7 @@ export class RepairBid extends Component {
       return;
 
     return this.verifyBid(parsed);
-  };
+  }
 
   async verifyBid(value) {
     const {bid} = this.props;