ui: no overflow for records

overflow was added for #119 in Auctions page Bids, but also affected Records in Domain Manager
kyokan · Feb 6, 2022 · c241c5d · c241c5d
1 parent c1288f5
commit c241c5d
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 3 deletions.
diff --git a/app/components/Collapsible/collapsible.scss b/app/components/Collapsible/collapsible.scss
@@ -38,7 +38,6 @@
     // padding: 1rem;
     position: relative;
     max-height: 35rem;
-    overflow-y: auto;
     height: auto;
     transition: 0.5s ease-out;
 
@@ -48,5 +47,9 @@
       overflow: hidden;
       transition: 0.5s ease-out;
     }
+
+    &--overflowY {
+      overflow-y: auto;
+    }
   }
 }
diff --git a/app/components/Collapsible/index.js b/app/components/Collapsible/index.js
@@ -10,11 +10,13 @@ export default class Collapsible extends Component {
     className: PropTypes.string,
     defaultCollapsed: PropTypes.bool,
     children: PropTypes.node.isRequired,
+    overflowY: PropTypes.bool,
   };
 
   static defaultProps = {
     className: '',
     defaultCollapsed: false,
+    overflowY: true,
   };
 
   static contextType = I18nContext;
@@ -65,7 +67,8 @@ export default class Collapsible extends Component {
   renderContent() {
     return (
       <div className={cn('collapsible__content', {
-        'collapsible__content--hidden': this.state.isCollapsed
+        'collapsible__content--hidden': this.state.isCollapsed,
+        'collapsible__content--overflowY': this.props.overflowY,
       })} >
         { this.props.children }
       </div>

diff --git a/app/pages/MyDomain/index.js b/app/pages/MyDomain/index.js
@@ -154,7 +154,7 @@ class MyDomain extends Component {
         <Collapsible className="my-domain__info-panel" title={t('domainDetails')} defaultCollapsed>
           <DomainDetails name={name} />
         </Collapsible>
-        <Collapsible className="my-domain__info-panel" title={t('records')}>
+        <Collapsible className="my-domain__info-panel" title={t('records')} overflowY={false}>
           <Records
             name={name}
             transferring={!!domain.info && domain.info.transfer !== 0}