Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Portfolio View should FINALIZE txs correctly #154

Closed
sdtsui opened this issue Jun 30, 2020 · 2 comments
Closed

[Feature] Portfolio View should FINALIZE txs correctly #154

sdtsui opened this issue Jun 30, 2020 · 2 comments

Comments

@sdtsui
Copy link
Contributor

sdtsui commented Jun 30, 2020

Current behavior: FINALIZE transactions show up as 'Unknown'
Screen Shot 2020-06-30 at 3 39 59 PM

Desired Behavior: we should display details similar to how we handle other name-related transactions. For example:
"Finalized Winning Bid ${name}/"
@pinheadmz
Copy link
Contributor

Was this fixed in the recent rebase and merge?

@rithvikvibhu
Copy link
Collaborator

Finalized transactions show up correctly. After #296, even "finalized with payment" transactions show correct labels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pinheadmz @rithvikvibhu @sdtsui