Fix tx value for atomic name swap finalize

[rithvikvibhu]

Fixes #292.

The value for atomic name swaps show up as 0. This PR shows the +ve/-ve amount for seller/buyer.

Note: I could only test with 2 name swaps, probably needs more testing. Also not sure if this is the best way to get the values, it's the shortest I could think of.

For the example below, 2 names transferred, c/ for 50 HNS, d/ without payment.

Sender:

Receiver:

[pinheadmz]

I think it'd be awesome if you could actually expand this list to include something like Received Payment for Finalize and Finalized With Payment

bob-wallet/app/components/Transactions/Transaction/index.js

Lines 131 to 133 in abdcdc8

	} else if (tx.type === 'FINALIZE') {
	description = 'Finalized Domain';
	content = this.formatDomain(tx.meta.domain);

[pinheadmz]

I could be wrong but I think if the wallet is receiving payment for a FINALIZE, then the payment value might just be equal to totalValue calculated above. I'm not sure if that'll work for the buyer though (who is sending money) but might save you some of the logic in the blob L371-390

[rithvikvibhu]

Yup, this works for the seller and I initially tried this (but outside the for loop because totalValue won't be complete inside the loop).

if (covAction) {
    return {
      ...covData,
      fee: tx.fee,
      value: covenant.action === 'FINALIZE' ? totalValue : covValue, // <- instead of just covValue
    };
  }

Like you said, this only works for the seller, not buyer. There's also a problem of identifying if the value is +ve or -ve.

[rithvikvibhu]

Rebased on master (well actually started from scratch). Now it works properly, tested with names with actual value. Finalize with/without work. Also updated transaction labels.

Seller's side (no payment, with payment):

Buyer's side (no payment, with payment):