Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passphrase not validated for each signing request. #472

Closed
eskimo opened this issue Feb 16, 2022 · 2 comments · Fixed by #476
Closed

Passphrase not validated for each signing request. #472

eskimo opened this issue Feb 16, 2022 · 2 comments · Fixed by #476
Labels
bug Something isn't working

Comments

@eskimo
Copy link

eskimo commented Feb 16, 2022

When you sign a your first message, it properly validates your password, however on subsequent signings it presents the modal yet you can simply type anything as your passphrase and it will be accepted.

Expected Behavior

Shouldn't sign if a wrong passphrase is entered

Current Behavior

Signs regardless of what passphrase is entered

Steps to Reproduce

  1. Enter a message
  2. Click sign
  3. Enter your passphrase
  4. Enter another message
  5. Type in random text in the passphrase field

Screencap

6917b78b.mp4
@pinheadmz
Copy link
Contributor

I think this has been discussed in other issues: when you enter your wallet passphrase, the wallet is "unlocked" for a default timeout of 60 seconds. During that time, anything can be signed with your private keys. Entering an incorrect passphrase during that time does NOT lock the wallet again. Completing a signature does NOT lock the wallet again.

@eskimo
Copy link
Author

eskimo commented Feb 16, 2022

If that's the case, the modal should either 1. not show if the current state is unlocked, and/or 2. an invalid passphrase should lock it.

@rithvikvibhu rithvikvibhu added the bug Something isn't working label Feb 22, 2022
rithvikvibhu added a commit to rithvikvibhu/bob-wallet that referenced this issue Feb 25, 2022
rithvikvibhu added a commit to rithvikvibhu/bob-wallet that referenced this issue Apr 20, 2022
Falci pushed a commit to Falci/bob-wallet that referenced this issue Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants