Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hsd: bump hsd to 0.2.3 #294

Closed
wants to merge 2 commits into from
Closed

hsd: bump hsd to 0.2.3 #294

wants to merge 2 commits into from

Conversation

chikeichan
Copy link
Contributor

This PR updates bob to this branch of kyokan/hsd, which is rebased update to this commit in hsd

@pinheadmz
Copy link
Contributor

ok awesome, lets wait until handshake-org/hsd#538 is merged into hsd as well so the official version number gets included in the package.json and therefore the peer metadata.

Also had another thought about this. What do you think about changing the pkg name in Bob:

https://github.com/kyokan/hsd/blob/kma2.3/lib/pkg.js#L17

to bob-hsd or something?

Then in getpeerinfo it will be revealed:

...
 "subver": "/bob-hsd:0.0.0/",
...

I know this is a privacy leak but I think it will be helpful in network analysis if anything goes wrong at the p2p or consensus layer. Bob is kinda an alternative implementation of hsd, it might be good to know that.

@chikeichan
Copy link
Contributor Author

closing for #301

@chikeichan chikeichan closed this Feb 17, 2021
@chikeichan chikeichan deleted the bump-hsd-0.2.3 branch June 20, 2021 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants