Ledger: handle *All, *Many transactions #375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The build fail is because of missing |
|
Awesome dude! I tested with ledger nano S physical device app version v1.0.4 and successfully revealed TEN bids in one TX! Hell yeah. One minor UI question - when we reveal multiple bids, maybe there is another thing to display here instead of just one of the names (like either all if possible or none?)
|
|
Ok, confirmed success with batch register and renew now also... |
|
Last test I did was to create a register that required a change output, which was handled perfectly with |
pinheadmz
approved these changes
Jun 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Ledger support for:
createTransferMany)createFinalizeMany)createRegisterAll)createRenewMany)Afaik, these were the only pending methods for Ledger. If there's any missed, I can include them too.