Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove atomic swap limit #441

Merged
merged 3 commits into from
Jan 17, 2022
Merged

Remove atomic swap limit #441

merged 3 commits into from
Jan 17, 2022

Conversation

altslash
Copy link
Contributor

Limit of 2000 HNS for finalize with payment significantly reduces the usefulness of the feature, this PR removes the limit.

Limit of 2000 HNS for finalize with payment significantly reduces the usefulness of the feature, this PR removes the limit.
@pinheadmz
Copy link
Contributor

untested ACK. Closes #399

I think it's been around long enough we can remove the limit. Could still be an unknown security issue though. But so far no one to my knowledge has totally lost their payment.

const isValid = !!this.state.price && (
!!this.state.price && Number(this.state.price) <= 2000
);
const isValid = !!this.state.price;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @altslash ! - i pushed a change that also removed the frontend gating

@chikeichan chikeichan merged commit a7cdc4b into kyokan:master Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants