Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.0.0 has more errors and maybe less complete than v1.5.1 #29

Closed
anthonyfok opened this issue Feb 1, 2019 · 2 comments
Closed

v2.0.0 has more errors and maybe less complete than v1.5.1 #29

anthonyfok opened this issue Feb 1, 2019 · 2 comments

Comments

@anthonyfok
Copy link
Contributor

While it is good that Issue #20 expressed the desire to have a more up-to-date and more complete emoji list, the update to emojo_v5 in PR #27 for v2.0.0 has actually introduced errors and caused some regressions which deter users from upgrading to v2.0.0 and instead opting to stay with v1.5.1.

The emoji-v5.json from CodeFreezr/emojo_v5, as is right now, contains errors:

  1. "Tags": "#ERROR!" in all 6 "thumbs up" emojis CodeFreezr/emojo#2 — "Tags": "#ERROR!" in all 6 "thumbs up" emojis
  2. Two emojis with "" as shortcode CodeFreezr/emojo#3 — Two emojis with "" (empty string) as shortcode
  3. Since only one shortcode is listed per emoji, popular shortcodes like :+1: 👍 and :-1: 👎 are not in the list.

The error CodeFreezr/emojo#3 crept into your emoji code map, e.g.:

// Mapping from character to concrete escape code.
var emojiCodeMap = map[string]string{
	"::":                                "\U0001f590",

when v1.5.1 had

	":raised_hand_with_fingers_splayed:":     "\U0001f590",

With :+1:, :-1:, :email: and perhaps more emoji shortcodes from v1.5.1 no longer in v2.0.0, users who have written content (e.g. blog posts) with these shortcodes in the past would see their content broken after upgrading to v2.0.0. That may be the reason why Hugo (the static website generator) is sticking with v1.5.1 and not upgrading to v2.0.0.

So, yes, it could be quite a bit of work to do so, but it would be really nice if a future updates could maintain compatibility with v1.5.1 while including new emojis from v5 or even v11 or v12.

Many thanks for your kind consideration!

@kyokomi
Copy link
Owner

kyokomi commented Feb 2, 2019

So, yes, it could be quite a bit of work to do so, but it would be really nice if a future updates could maintain compatibility with v1.5.1 while including new emojis from v5 or even v11 or v12.

Thank you for the report. I will examine this method 🙏

@kyokomi
Copy link
Owner

kyokomi commented Feb 2, 2019

@anthonyfok Fixed in #30. Please confirm 🙏

@kyokomi kyokomi closed this as completed May 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants