You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While it is good that Issue #20 expressed the desire to have a more up-to-date and more complete emoji list, the update to emojo_v5 in PR #27 for v2.0.0 has actually introduced errors and caused some regressions which deter users from upgrading to v2.0.0 and instead opting to stay with v1.5.1.
The emoji-v5.json from CodeFreezr/emojo_v5, as is right now, contains errors:
With :+1:, :-1:, :email: and perhaps more emoji shortcodes from v1.5.1 no longer in v2.0.0, users who have written content (e.g. blog posts) with these shortcodes in the past would see their content broken after upgrading to v2.0.0. That may be the reason why Hugo (the static website generator) is sticking with v1.5.1 and not upgrading to v2.0.0.
So, yes, it could be quite a bit of work to do so, but it would be really nice if a future updates could maintain compatibility with v1.5.1 while including new emojis from v5 or even v11 or v12.
Many thanks for your kind consideration!
The text was updated successfully, but these errors were encountered:
So, yes, it could be quite a bit of work to do so, but it would be really nice if a future updates could maintain compatibility with v1.5.1 while including new emojis from v5 or even v11 or v12.
Thank you for the report. I will examine this method 🙏
While it is good that Issue #20 expressed the desire to have a more up-to-date and more complete emoji list, the update to emojo_v5 in PR #27 for v2.0.0 has actually introduced errors and caused some regressions which deter users from upgrading to v2.0.0 and instead opting to stay with v1.5.1.
The emoji-v5.json from CodeFreezr/emojo_v5, as is right now, contains errors:
:+1:
👍 and:-1:
👎 are not in the list.The error CodeFreezr/emojo#3 crept into your emoji code map, e.g.:
when v1.5.1 had
With
:+1:
,:-1:
,:email:
and perhaps more emoji shortcodes from v1.5.1 no longer in v2.0.0, users who have written content (e.g. blog posts) with these shortcodes in the past would see their content broken after upgrading to v2.0.0. That may be the reason why Hugo (the static website generator) is sticking with v1.5.1 and not upgrading to v2.0.0.So, yes, it could be quite a bit of work to do so, but it would be really nice if a future updates could maintain compatibility with v1.5.1 while including new emojis from v5 or even v11 or v12.
Many thanks for your kind consideration!
The text was updated successfully, but these errors were encountered: