ReverseCodeMap, map unicode character to lists of short codes #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyokomi
reviewed
Apr 2, 2020
| @@ -99,7 +137,7 @@ func Println(a ...interface{}) (int, error) { | |||
|
|
|||
| // Printf is fmt.Printf which supports emoji | |||
| func Printf(format string, a ...interface{}) (int, error) { | |||
| return fmt.Printf(compile(fmt.Sprintf(format, a...))) | |||
| return fmt.Print(compile(fmt.Sprintf(format, a...))) | |||
There was a problem hiding this comment.
Is there a reason for this change?
There was a problem hiding this comment.
Changed from the output of https://github.com/golangci/golangci-lint
$ golangci-lint run .
emoji_test.go:189:22: S1019: should use make([]byte, buff.Len()) instead (gosimple)
bc := make([]byte, buff.Len(), buff.Len())
^
emoji.go:140:20: SA1006: printf-style function with dynamic format string and no further arguments should use print-style function instead (staticcheck)
return fmt.Printf(compile(fmt.Sprintf(format, a...)))
^
Happy to move to a separate PR or remove if you want!
There was a problem hiding this comment.
I see . Thank you, I understand 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thought this might be useful upstream for shortcode alias support.