Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add emoji data source #36

Merged
merged 1 commit into from
Apr 2, 2020
Merged

Conversation

joshblum
Copy link
Contributor

@joshblum joshblum commented Apr 2, 2020

Helpful to view the diff without whitespace changes: https://github.com/kyokomi/emoji/pull/36/files?diff=unified&w=1

Incorporates the emoji source https://github.com/iamcal/emoji-data into the library

@joshblum joshblum marked this pull request as ready for review April 2, 2020 14:03
Copy link
Owner

@kyokomi kyokomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Thanks. LGTM 👍

@kyokomi kyokomi merged commit c791814 into kyokomi:master Apr 2, 2020
@joshblum joshblum deleted the joshblum/emojisrc branch April 2, 2020 15:37
joshblum added a commit to joshblum/emoji-data that referenced this pull request Apr 4, 2020
iamcal pushed a commit to iamcal/emoji-data that referenced this pull request May 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants