Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add go mod support #45

Merged
merged 1 commit into from
May 11, 2020
Merged

add go mod support #45

merged 1 commit into from
May 11, 2020

Conversation

MichaelMure
Copy link
Contributor

Even if this package doesn't have any dependencies, it's still a nice thing to have, at least for avoiding the v2.2.2+incompatible when importing.

This is a double go.mod setup to avoid having the generator dependencies pulled when simply importing the package.

Copy link
Owner

@kyokomi kyokomi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@kyokomi kyokomi merged commit 9287703 into kyokomi:master May 11, 2020
@MichaelMure
Copy link
Contributor Author

Could you also tag a release ?

@kyokomi
Copy link
Owner

kyokomi commented May 12, 2020

🙏 I just tagged now.
https://github.com/kyokomi/emoji/releases/tag/v2.2.3

@MichaelMure
Copy link
Contributor Author

MichaelMure commented May 12, 2020 via email

@tulir
Copy link

tulir commented Jun 7, 2020

Shouldn't it be module github.com/kyokomi/emoji/v2 to actually work? As far as I can tell, v2.2.3 is completely unusable

go: github.com/kyokomi/emoji/v2@v2.2.3: go.mod has non-.../v2 module path "github.com/kyokomi/emoji" (and .../v2/go.mod does not exist) at revision v2.2.3

@kyokomi
Copy link
Owner

kyokomi commented Jun 9, 2020

@tulir Thanks for the comment. I fixed it here.

24a0d8a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants