Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Need to rework render function to support classic templates too #85

Closed
adhd42 opened this issue Dec 4, 2021 · 2 comments
Closed

Need to rework render function to support classic templates too #85

adhd42 opened this issue Dec 4, 2021 · 2 comments
Labels
enhancement New feature or request external request Features, requested by users
Milestone
v1.0.0

Comments

@adhd42
Copy link
Collaborator

adhd42 commented Dec 4, 2021

Is your feature request related to a problem? Please describe.
render template function only supports components with defined custom rendering.

Describe the solution you'd like
It would be great to rework render function to be universal and make it a standard function for rendering components instead of explicit {{ template "ComponentExample" .ComponentExample }}
@adhd42 adhd42 added enhancement New feature or request external request Features, requested by users labels Dec 4, 2021
@adhd42 adhd42 added this to the v0.3 milestone Dec 4, 2021
@adhd42
Copy link
Collaborator Author

adhd42 commented Jan 19, 2022

Function was excluded in latest refactor. Need to re-implement it

@adhd42 adhd42 modified the milestones: v0.3, v1.0 Feb 6, 2022
@adhd42 adhd42 mentioned this issue Mar 17, 2022
Closed
adhd42 added a commit that referenced this issue Apr 9, 2022
@adhd42
close #112, #85: custom rendering
927d8e6 
- rename "render.Custom" to "render.Writer"
- change "render.FuncMap" signature to accept core
- change "actions.Handler" template builder signature to accept core
- fix "render.Writer" logic
- implement "render.Render" function
@adhd42 adhd42 closed this as completed Apr 9, 2022
@adhd42
Copy link
Collaborator Author

adhd42 commented Apr 10, 2022

Feature described in https://kyoto.codes/features/alternative-rendering/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request external request Features, requested by users
Projects
None yet
Milestone
v1.0.0
Development

No branches or pull requests
1 participant
@adhd42