Refactor to interfaces #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 8, 2021
|
Thanks so much 馃槃 |
This was referenced Feb 9, 2021
Merged
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is the first one which addresses some of the notes mentioned in #35
This PR introduce two new interfaces:
src/TrackingFilterInterface.php: Used to check whether or not a given request should be logged.src/TrackingLoggerInterface.php: Used to log the requestAnd two concrete implementations of these new interfaces:
src/TrackingFilter.phpsrc/TrackingLogger.phpWhere the content of the two concrete classes are directly copy-pasted from the
src/Middleware/CaptureAttributionDataMiddleware.phpwhich is now significantly slimmer 馃憤Tests
This PR also implements basic tests for the middleware and empty tests for the two concrete classes described above (no tests were implemented before).
An an abstract
TestCaseclass was introduced and some modifications to the file structure and dev requirements had to be made for the tests to be implemented.