Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

impl Debug for LruCache #4

Merged
merged 1 commit into from
Oct 6, 2020
Merged

impl Debug for LruCache #4

merged 1 commit into from
Oct 6, 2020

Conversation

thomcc
Copy link
Contributor

@thomcc thomcc commented Oct 5, 2020

Compatibility with lru-cache crate (also just generally a nice to have thing).

@kyren
Copy link
Owner

kyren commented Oct 6, 2020

Yeah this makes perfect sense, and I agree with .rev() to show the most recently used entries first.

I think LinkedHashMap is also missing a Debug impl and needs it? I'll merge this and then add that as well.

Edit: oh it's there I'm just blind :/

@kyren kyren merged commit 97218cf into kyren:master Oct 6, 2020
@thomcc
Copy link
Contributor Author

thomcc commented Oct 6, 2020

Edit: oh it's there I'm just blind :/

Yeah, I checked for this too, it's buried a bit lol (impls tend to get this way in data structure crates tho).

It would be nice if you cut a release but isn't that big of a deal since it turned out it was only needed for a non-public type.

@kyren
Copy link
Owner

kyren commented Oct 6, 2020

It would be nice if you cut a release but isn't that big of a deal since it turned out it was only needed for a non-public type.

Actually I was planning on doing this, but in reviewing the Debug impls I noticed that the trait bounds were way too strict, and that pulled a thread of relaxing the bounds on various IntoIterator impls, iter methods, etc.

I think I got it though, and pushed d9b5a7e, so I think I can make a release now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants