Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iterable inside AcquisitionLoop.iter() should not be converted into list #57

Closed
kyrylo-gr opened this issue Aug 9, 2023 · 1 comment
Closed

iterable inside AcquisitionLoop.iter() should not be converted into list #57

kyrylo-gr opened this issue Aug 9, 2023 · 1 comment
Assignees
@kyrylo-gr
Labels
bug Something isn't working

Comments

@kyrylo-gr
Copy link
Owner

Currently, it is not possible to iterate through an iterable within AcquisitionLoop.

Here is an example of what should be possible:

def some_iterator(x_list):
    for x in x_list:
        go_to(x) # here it's important that AcquisitionLoop iterate with this iterator and not independently 
        yield x


loop = AcquisitionLoop()

for x in loop.iter(some_iterator):
    ...
@kyrylo-gr kyrylo-gr self-assigned this Aug 9, 2023
@kyrylo-gr kyrylo-gr added the bug Something isn't working label Aug 9, 2023
kyrylo-gr added a commit that referenced this issue Aug 10, 2023
@kyrylo-gr
Feat: continue to take AcquisitionLoop (#56)
40650c8 
Solve:
- #56: remove AcquisitionLoopOld
- #57: don't convert to list inside AcquisitionLoop
- AcquisitionLoop can be initialized from data
- SyncNp doesn't resave data when init
@kyrylo-gr
Copy link
Owner Author

solved with v0.8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kyrylo-gr kyrylo-gr

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kyrylo-gr