Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add FETCH clause support. #822

Merged
merged 17 commits into from
Feb 24, 2024
Merged

add FETCH clause support. #822

merged 17 commits into from
Feb 24, 2024

Conversation

igalklebanov
Copy link
Member

@igalklebanov igalklebanov commented Dec 29, 2023 •
edited

Hey 👋

fetch clause is supported in dialects such as PostgreSQL, MS SQL Server (MSSQL) and OracleDB.

It works just like limit, but sometimes limit is not supported, so here we are.

It is only supported in select queries, or when they're used as subqueries in top-level insert/delete/update queries.

This PR also:

  • expands limit and offset by allowing bigints.
  • fixes mssql offset compilation.

@igalklebanov igalklebanov added api Related to library's API enhancement New feature or request mssql Related to MS SQL Server (MSSQL) oracle Related to Oracle postgres Related to PostgreSQL labels Dec 29, 2023
@vercel Vercel
Copy link

vercel bot commented Dec 29, 2023 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
kysely ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 24, 2024 11:49am

@igalklebanov igalklebanov marked this pull request as ready for review December 30, 2023 00:01
@igalklebanov igalklebanov mentioned this pull request Dec 30, 2023
Merged
@igalklebanov igalklebanov merged commit eb4eb56 into kysely-org:master Feb 24, 2024
5 checks passed
@igalklebanov igalklebanov deleted the feat-offset-fetch branch February 24, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koskimas koskimas koskimas approved these changes

Assignees
No one assigned
Labels
api Related to library's API enhancement New feature or request mssql Related to MS SQL Server (MSSQL) oracle Related to Oracle postgres Related to PostgreSQL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@igalklebanov @koskimas