Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: @rest endpoints are now run by starlette/uvicorn instead of flask/werkzeug #129

Merged
merged 9 commits into from
May 3, 2023

Conversation

viniarck
Copy link
Member

@viniarck viniarck commented Apr 24, 2023

Closes #123
Closes #124

This PR depends on kytos-ng/kytos#375

(I'll revert the pinned branch feat/starlette on requirements/dev.in later on, it's need for tests to pass)

Summary

See updated changelog file.

Notice that requirements/dev.in is being used directly now instead of requirements/dev.txt to simplify code maintenance and house keeping, for more information check out the linked issue, in summary, we're making a trade-off to trust kytos-ng dev upstream transitive dependencies.

Local Tests

  • Exercised with a ring topology a few endpoints
2023-04-24 11:56:38,288 - INFO [kytos.napps.kytos/of_core] (thread_pool_sb_0) Connection ('127.0.0.1', 38790), Switch 00:00:00:00:00:00:00:01: OPENFLOW HANDSHAKE COMPLETE
2023-04-24 11:56:38,289 - INFO [kytos.napps.kytos/of_core] (thread_pool_sb_0) Connection ('127.0.0.1', 38800), Switch 00:00:00:00:00:00:00:03: OPENFLOW HANDSHAKE COMPLETE
2023-04-24 11:56:38,291 - INFO [kytos.napps.kytos/of_core] (thread_pool_sb_0) Connection ('127.0.0.1', 38802), Switch 00:00:00:00:00:00:00:02: OPENFLOW HANDSHAKE COMPLETE
2023-04-24 11:56:44,424 - INFO [uvicorn.access] (ThreadPoolExecutor-1_0) 127.0.0.1:41246 - "GET /api/kytos/topology/v3/ HTTP/1.1" 200
2023-04-24 11:56:47,406 - INFO [uvicorn.access] (ThreadPoolExecutor-1_0) 127.0.0.1:41246 - "GET /api/kytos/topology/v3/interfaces HTTP/1.1" 200
2023-04-24 11:56:51,848 - INFO [uvicorn.access] (ThreadPoolExecutor-1_0) 127.0.0.1:41246 - "GET /api/kytos/topology/v3/interfaces HTTP/1.1" 200

End-to-End Tests

e2e tests with this PR and related starlette PRs can be found here, they're passing

@viniarck viniarck requested a review from a team as a code owner April 24, 2023 15:12
@viniarck viniarck marked this pull request as draft April 24, 2023 15:13
@viniarck viniarck marked this pull request as ready for review May 1, 2023 15:33
requirements/dev.in Outdated Show resolved Hide resolved
requirements/dev.in Outdated Show resolved Hide resolved
@viniarck viniarck merged commit 93952b5 into master May 3, 2023
@viniarck viniarck deleted the chore/starlette branch May 3, 2023 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant