Fix linter issues

kytos/core/api_server.py

@@ -25,6 +25,7 @@ class APIServer:
     _NAPP_PREFIX = "/api/{napp.username}/{napp.name}/"
     _CORE_PREFIX = "/api/kytos/core/"
 
+    # pylint: disable=too-many-arguments
     def __init__(self, app_name, listen='0.0.0.0', port=8181,
                  napps_manager=None, napps_dir=None):
         """Start a Flask+SocketIO server.
@@ -464,12 +465,12 @@ def _get_napp_metadata(self, username, napp_name, key):
         napp_dependencies, description, version.
 
         """
-        _VALID_KEYS = ['napp_dependencies', 'description', 'version']
+        valid_keys = ['napp_dependencies', 'description', 'version']
 
         if not self.napps_manager.is_installed(username, napp_name):
             return "NApp is not installed.", HTTPStatus.BAD_REQUEST.value
 
-        if key not in _VALID_KEYS:
+        if key not in valid_keys:
             return "Invalid key.", HTTPStatus.BAD_REQUEST.value
 
         data = self.napps_manager.get_napp_metadata(username, napp_name, key)

kytos/core/connection.py

@@ -2,8 +2,8 @@
 import logging
 from enum import Enum
 from errno import EBADF, ENOTCONN
-from socket import error as SocketError
 from socket import SHUT_RDWR
+from socket import error as SocketError
 
 __all__ = ('Connection', 'ConnectionProtocol', 'ConnectionState')
 

kytos/core/controller.py

@@ -22,8 +22,8 @@
 import sys
 import threading
 from concurrent.futures import ThreadPoolExecutor
-from importlib import reload as reload_module
 from importlib import import_module
+from importlib import reload as reload_module
 from importlib.util import module_from_spec, spec_from_file_location
 from pathlib import Path
 
@@ -571,7 +571,7 @@ def set_switch_options(self, dpid):
             self.log.error("Invalid vlan_pool settings: %s", err)
 
         if vlan_pool.get(dpid):
-            self.log.info(f"Loading vlan_pool configuration for dpid {dpid}")
+            self.log.info("Loading vlan_pool configuration for dpid %s", dpid)
             for intf_num, port_list in vlan_pool[dpid].items():
                 if not switch.interfaces.get((intf_num)):
                     vlan_ids = set()

kytos/core/interface.py

@@ -107,6 +107,7 @@ def id(self):  # pylint: disable=invalid-name
 
         Returns:
             string: Interface id.
+
         """
         return "{}:{}".format(self.switch.dpid, self.port_number)
 

tests/test_core/test_interface.py

@@ -5,7 +5,7 @@
 
 from pyof.v0x04.common.port import PortFeatures
 
-from kytos.core.interface import Interface, TAG, TAGType
+from kytos.core.interface import TAG, Interface, TAGType
 from kytos.core.switch import Switch
 
 logging.basicConfig(level=logging.CRITICAL)

tests/test_core/test_switch.py

@@ -28,7 +28,7 @@ def tearDown(self):
 
     def test_switch_vlan_pool_default(self):
         """Test default vlan_pool value."""
-        self.assertEqual(self.options.vlan_pool, {})
+        self.assertEqual(self.options.vlan_pool, '{}')
 
     def test_switch_vlan_pool_options(self):
         """Test switch with the example from kytos.conf."""