Skip to content
This repository has been archived by the owner on Apr 22, 2024. It is now read-only.

Do not disable any logger #430

Merged
merged 3 commits into from
May 22, 2017
Merged

Do not disable any logger #430

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1024816
Do not disable any logger
cemsbr May 18, 2017
364bd01
[minor] LogManager: code review, bug fix, tests
cemsbr May 19, 2017
0182780
[minor] LogManager review, refactoring, 100% ccov
cemsbr May 20, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion kytos/core/logs.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ def load_logging_file(cls, logging_file):
cls.configuration.read(logging_file)

try:
config.fileConfig(logging_file)
config.fileConfig(logging_file, disable_existing_loggers=False)
except FileNotFoundError:
cls.configuration.set('handler_syslog', 'args', '[]')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you forgot to verify the handler_syslog. This line change the 'handler_syslog' if the file /dev/syslog don't exists.

config.fileConfig(cls.configuration)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not the line be here too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch. I refactored not to repeat code.

Expand Down