This repository has been archived by the owner on Apr 22, 2024. It is now read-only.
Socketio #436
Merged
Socketio #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecated in favor of a more robust web socket.
Changes: - Long-polling for logs - Messages are instantaneously published - Remove periodic requests every 3 seconds - Remove backend log buffer - Replace socketio namespaces by rooms - Chromium/Chrome changes: - Faster log rendering (fix kytos#427) - No more strange characters in log panel - Remove INFO logs about web-UI own requests (close kytos#429)
diraol
reviewed
May 24, 2017
kytos/core/websocket.py
Outdated
|
|
||
| def __init__(self, socketio): | ||
| """Receive the socket to write to.""" | ||
| super().__init__() |
There was a problem hiding this comment.
@cemsbr this WebSocketStream class does not inherit from other classes, why calling the super().__init__() here?
kytos/web-ui/static/js/kytos-logs.js
Outdated
| turn_off_led() | ||
| console.log('disconnected') | ||
| }) | ||
| function disconnect() { |
There was a problem hiding this comment.
@cemsbr may be it is better to call this method something like announce_disconnection ou disconnected, since it does not perform the disconnection itself
|
@diraol, I applied your suggestions. |
diraol
approved these changes
May 24, 2017
Merged
macartur
approved these changes
May 26, 2017
beraldoleal
suggested changes
Jun 13, 2017
kytos/web-ui/index.html
Outdated
| <li class="nav-kytos-api-status"> | ||
| <i class="fa fa-power-off api-status" aria-hidden="true"></i> | ||
| <span class='hidden-sm hidden-xs'>Kytos </span>API | ||
| </li> |
There was a problem hiding this comment.
Please, let's keep this led until everything become web socket.
| Do not print web requests (INFO level) to avoid infinit loop when | ||
| printing the logs in the web interface with long-polling mode. | ||
| """ | ||
| return record.name != 'werkzeug' or record.levelno > logging.INFO |
There was a problem hiding this comment.
Please open an issue in order to us use a proper websocket listen. Maybe with wampp
API status LED makes HTTP requests every 2 seconds.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This a big change. Review by commit is recommended.