-
-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CSS not exported from package #35
Comments
Hey Paul, yeah, I haven't tested the CSS imports in non-browser environments... I am currently working on a version 2.0 of share on, where I will introduce some breaking changes but, through this, improve the imports and exports. I will also try to fix this issue in v1.x until weekend, but I can't promise I can implement this without breaking anything 😅 I'll keep you updated |
Hey Paul @totallyspun, I am terribly sorry for taking so long! I am currently preparing the new Shareon release, v2.0.0. I have upgraded the way Shareon works and also moved the repository to a different source code hosting: Codeberg. This repo, however, will stay as a mirror. I have now published a beta version: You now import Shareon's JS like this: import { init } from "shareon";
init(); // will initialize the buttons or this: const Shareon = require("shareon");
Shareon.init(); // will initialize the buttons CSS exports would then work like this: import "shareon/css"; or this: require("shareon/css"); Could you test it and tell me, if this works in your setup? I have sadly no experience with such CSS imports, so I can't really test it. |
Hi again Paul, I've tested it on a simple Vite-built website, and it seems to actually work! I have now released the v2; you don't need to use the beta version any more. If you still experience problems, don't hesitate to open a new issue or contact me personally 😄 |
Hey, thanks for keeping track of this!
I’m not needing it on my current project, but will check it next time I need a share feature.
Cheers!
From: Nikita Karamov ***@***.***>
Date: Sunday, February 13, 2022 at 10:14 AM
To: kytta/shareon ***@***.***>
Cc: Paul Reynolds ***@***.***>, Mention ***@***.***>
Subject: Re: [kytta/shareon] CSS not exported from package (#35)
Hi again Paul,
I've tested it on a simple Vite-built website, and it seems to actually work! I have now released the v2; you don't need to use the beta version any more. If you still experience problems, don't hesitate to open a new issue or contact me personally 😄
—
Reply to this email directly, view it on GitHub<#35 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAATS5CWU4D6N2CTEOF77T3U27C57ANCNFSM47SRAPVQ>.
Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Hi,
I am trying to use shareon within a Webpack project, but I cannot import the styles, I get an error:
Package path ./dist/shareon.min.css is not exported from package /project/node_modules/shareon (see exports field in /project/node_modules/shareon/package.json)
My workaround is to import the styles from cdn, but I am wondering if the package exports can be updated in a future revision.
Thanks!
The text was updated successfully, but these errors were encountered: