Added tumblr button #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kytta
requested changes
Jul 27, 2023
There was a problem hiding this comment.
Thanks for your submission!
One of the reasons why the button would not work is because you define new fields for page metadata (aka the d object), but you never fill them, which would happen in init() (see line starting with const preset =).
However, we do not really need new parameters, as we could reuse the old ones. Follow my suggestions to update the PR.
kytta
requested changes
Jul 28, 2023
|
Oh, thanks a lot for fixing the ordering of MS Teams, too! 😄 I'll test it and hopefully release a new version today |
kytta
approved these changes
Jul 31, 2023
|
Too late for me to release a new version; I hope it comes out tomorrow. Good night from my side, and thanks for the contribution! |
|
welcome Kytta. Thank you for the guidance I hope to contribute more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tumblr button.
closes #76