Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile target with variables should be run using variable content #156

Open
Sigmanificient opened this issue Dec 17, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@Sigmanificient
Copy link
Contributor

In many Makefiles, rules are defined using make variables.
When trying to call such a target, it should use the variable content.

For instance, selecting the $(BUILD_DIR) option should run make .build because make $(BUILD_DIR) is invalid
Recipes (rule including a wildcard (%)) should also not appear in the selection menu.

Peek 2023-12-17 05-02

@kyu08
Copy link
Owner

kyu08 commented Jan 1, 2024

I'm sorry for the late reply. I haven't have enough time for recent few days.

About a target includes make variables

That's right. I'm sorry but, fzf-make can't execute a target including make variables for now.
To resolve this issue, make parser like this can be useful. After resolving some other issues, I will take a time for this problem.

About a target includes wildcard

At first, that the target has only one character is not shown in selection window has been cause by another bug. (#161)
I didn't notice that behavior, thanks for the report!

Apart from that, if my understanding is correct, in order to execute a target including a wildcard, it is necessary to ask the user to specify the content of the wildcard after selecting target.
I think it would be good to display an additional modal when a target including a wildcard is selected.
I created a issue(#162) for this enhancement.

@kyu08 kyu08 added the enhancement New feature or request label Jan 1, 2024
@kyu08 kyu08 added this to the Within few release milestone Jan 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants