forked from codesquad-members-2021/baseball
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Be/feature/api PR #17
Merged
Merged
Changes from 9 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
0f1bed2
Feature : 게임 상세페이지 구현
choitree a8bd322
Feature : 게임 공격/수비 페이지 구현
choitree d29f70c
Feature : 구조 변경에 따라 schema 변경
choitree 5639403
Feature : 샘플 데이터 추가
choitree ef95de0
Feature : 게임 목록 구현
choitree 2cb83e7
Fix : ballCount 테이블 분리
choitree 49a1f9e
Fix : ballCount 테이블 분리
choitree 13ddb85
Feature : ScoreRepository 메소드 추가
choitree d0c07ca
Feature : Game Score 로직 구현 (1차 수정)
choitree f40b66e
Feature : Game Score 로직 구현 (2차 수정)
choitree e93bc73
Feature : 상세페이지 확인하기 구현
choitree 82f33ae
Feature : 수비/공격 페이지 구현 (get/put)
choitree 84b69b3
chore : application.properties에 url 포트번호 수정
choitree 0aa9e91
chore : 샘플데이터 추가
choitree 92fb9c7
chore : 샘플데이터 추가
choitree ae9fe69
fix : 대소문자 구별
kyupid cc03335
fix : 버그 수정
choitree 62ce68f
Merge branch 'tree/ballCount' of https://github.com/kyu-kim-kr/baseba…
choitree 15c199e
fix : 포트번호 변경
kyupid ffac0f3
add : 선수 데이터 추가
kyupid 54991a6
Add : /delete 기능 추가
choitree 4163826
Merge pull request #20 from kyupid/tree/ballCount
kyupid File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
38 changes: 38 additions & 0 deletions
38
BE/src/main/java/com/example/baseball/dto/BallCountDTO.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,38 @@ | ||
package com.example.baseball.dto; | ||
|
||
import com.example.baseball.entity.BallCount; | ||
|
||
public class BallCountDTO { | ||
|
||
private Long id; | ||
private String playerName; | ||
private String ball; | ||
private Long gameId; | ||
|
||
public BallCountDTO(Long id, String playerName, String ball, Long gameId) { | ||
this.id = id; | ||
this.playerName = playerName; | ||
this.ball = ball; | ||
this.gameId = gameId; | ||
} | ||
|
||
public Long getId() { | ||
return id; | ||
} | ||
|
||
public String getPlayerName() { | ||
return playerName; | ||
} | ||
|
||
public String getBall() { | ||
return ball; | ||
} | ||
|
||
public Long getGameId() { | ||
return gameId; | ||
} | ||
|
||
public static BallCountDTO of(BallCount ballCount) { | ||
return new BallCountDTO(ballCount.getId(), ballCount.getPlayerName(), ballCount.getBall().getStatus(),ballCount.getGameId()); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34 changes: 34 additions & 0 deletions
34
BE/src/main/java/com/example/baseball/dto/PlayGameDTO.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
package com.example.baseball.dto; | ||
|
||
import java.util.ArrayList; | ||
import java.util.List; | ||
|
||
public class PlayGameDTO { | ||
private GameScoreResponseDTO gameScoreResponseDTO; | ||
private HalfInningGameResponseDTO halfInningGameResponseDTO; | ||
private List<PlayerResponseDTO> players = new ArrayList<>(2); //0 :투수, 1 :타자 | ||
private List<BallCountDTO> ballCounts; | ||
|
||
public PlayGameDTO(GameScoreResponseDTO gameScoreResponseDTO, HalfInningGameResponseDTO halfInningGameResponseDTO, List<PlayerResponseDTO> players, List<BallCountDTO> ballCounts) { | ||
this.gameScoreResponseDTO = gameScoreResponseDTO; | ||
this.halfInningGameResponseDTO = halfInningGameResponseDTO; | ||
this.players = players; | ||
this.ballCounts = ballCounts; | ||
} | ||
|
||
public GameScoreResponseDTO getGameScoreResponseDTO() { | ||
return gameScoreResponseDTO; | ||
} | ||
|
||
public HalfInningGameResponseDTO getHalfInningGameResponseDTO() { | ||
return halfInningGameResponseDTO; | ||
} | ||
|
||
public List<PlayerResponseDTO> getPlayers() { | ||
return players; | ||
} | ||
|
||
public List<BallCountDTO> getBallCounts() { | ||
return ballCounts; | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
여기 접근 제어자 바꿔줘야 할거 같아요
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
오 네네!!