Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make universal codegenerator toml specifiable in atcodertools.toml #237

Merged
merged 3 commits into from
Jul 18, 2021

Conversation

chaemon
Copy link
Contributor

@chaemon chaemon commented Jul 1, 2021

標記の通り、.atcoder-tools.tomlのcode_generator_tomlでuniversal_code_generatorのtomlを指定できるようにしました。言語ごとにも指定可能なはずです。

@codecov-commenter
Copy link

codecov-commenter commented Jul 1, 2021

Codecov Report

Merging #237 (0513537) into stable (f7a4121) will decrease coverage by 0.01%.
The diff coverage is 88.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##           stable     #237      +/-   ##
==========================================
- Coverage   89.20%   89.18%   -0.02%     
==========================================
  Files          58       59       +1     
  Lines        2519     2534      +15     
==========================================
+ Hits         2247     2260      +13     
- Misses        272      274       +2     
Impacted Files Coverage Δ
atcodertools/codegen/code_style_config.py 91.07% <80.00%> (-2.55%) ⬇️
atcodertools/codegen/code_generators/custom.py 100.00% <100.00%> (ø)
atcodertools/release_management/version.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e12602b...0513537. Read the comment docs.

@kyuridenamida
Copy link
Owner

よさそうです。テスト落ちているので確認しています

@kyuridenamida
Copy link
Owner

テスト通りましたね。マージします。

@kyuridenamida kyuridenamida merged commit 59a2378 into kyuridenamida:stable Jul 18, 2021
@kyuridenamida kyuridenamida changed the title universal codegeneratorのtomlをatcodertools.tomlで指定可能に Make universal codegenerator toml specifiable in atcodertools.toml Jul 18, 2021
@kyuridenamida kyuridenamida added this to the 2.6.0 milestone Jul 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants