Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor user config path setting #257

Merged
merged 2 commits into from
Jun 8, 2024

Conversation

pogin503
Copy link
Contributor

Why is this change needed?

Refactoring because the following source code does not use USER_CONFIG_PATH in atcodertools/config/config.py.
atcodertools/tools/compiler.py
atcodertools/tools/envgen.py

_(Japanese)
下記のソースコードでは、atcodertools/config/config.pyのUSER_CONFIG_PATHを使用していないためリファクタリング。
atcodertools/tools/compiler.py
atcodertools/tools/envgen.py

What did you implement?

Replaced the USER_CONFIG_PATH defined for each source code with the USER_CONFIG_PATH in atcodertools/config/config.py.

_(Japanese)

ソースコード毎に定義してあるUSER_CONFIG_PATHを、atcodertools/config/config.py のUSER_CONFIG_PATHに置き換えた。

What behavior do you expect?

If the atcoder-tools gen and atcoder-tools compile tests pass, you're good to go.
_(Japanese)

atcoder-tools genatcoder-tools compileのテストが通ればOK

@kyuridenamida kyuridenamida added this to the 2.14.1 milestone Jun 8, 2024
@kyuridenamida
Copy link
Owner

長らく放置してすみませんでしたが、良さそうなリファクタリングなので取り込ませてください!ありがとうございます。

@kyuridenamida kyuridenamida merged commit f3c8423 into kyuridenamida:stable Jun 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants