Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to newer Docker image in the readme #331

Closed
lukechilds opened this issue Dec 14, 2017 · 2 comments
Closed

Link to newer Docker image in the readme #331

lukechilds opened this issue Dec 14, 2017 · 2 comments

Comments

@lukechilds
Copy link
Contributor

I created my own Docker image (lukechilds/electrumx) due to some issues I had with the current image recommended in the readme (followtheart/electrumx).

The followtheart image doesn't follow Docker best practices and is also quite large and out of date. I believe my image is better because:

Size

lukechilds/electrumx: 40MB
followtheart/electrumx: 175MB

Follows Docker conventions

  • All settings are passed in as ENV vars (no need for ENV folder)
  • Runs ElectrumX directly as PID 1 instead of bash -> daemon
    • Interactive Docker sessions attach directly meaning Control-C works
    • Interactive Docker sessions get ElectrumX output to STDOUT
    • ElectrumX output will be piped to normal Docker logging tools
    • You shouldn't dockerize a daemon, the Docker image itself should be daemonized
  • Reproducible builds: separate branch for each release (followtheart container builds current master)

Up to date

Pulling from Docker Hub will pull the latest ElectrumX release. You can also specify a tag to pull specific older ElectrumX releases.

The latest followtheart build on Docker Hub is 6 months out of date.

Secure

If no SSL cert is provided one will be automatically generated on first boot.


Following these rules makes the image much easier to orchestrate in other Docker projects (e.g Dockerized Vertcoin Electrum Server), it's also currently the most used ElectrumX image on Docker Hub.

Let me know if you'd like to link to this image instead and I'll happily submit a PR.

@kyuupichan
Copy link
Owner

As I don't user Docker and @followtheart initially added this to the repo, I'd his/her thoughts.

Yes a PR would be nice. Please mention in the commit log it closes this issue.

lukechilds added a commit to lukechilds/electrumx that referenced this issue Dec 15, 2017
@lukechilds
Copy link
Contributor Author

Of course, opened a PR.

kyuupichan pushed a commit that referenced this issue Dec 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants