-
Notifications
You must be signed in to change notification settings - Fork 733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing import in chain_state query #559
Conversation
Can you give an example of what you mean by "it's querying items"? That would be something to fix in electrumx_rpc |
I mean args is a dict like: And the loop in query attemps to get a hex from args[0] i.e. ‘items’. |
Well that is what needs to be understood and fixed; ignoring an argument is not the answer. I'm not clear on why this worked fine for me |
This works fine for me:
Also with an address:
The bug is simply the missing import:
when neither a script hash nor an address is passed. So I don't understand your point about "items" |
You're right I misinterpreted the help instructions. I'll remove that change. |
Based on #559. Also: - remove unused import - restore timeout to 15s - handle invalid input by catching at a higher level and converting to RPCError
I fixed this in a3afab8 If you still have a problem with "items" can you open an issue. Thanks |
Missing Base58Error import
Also query method was querying 'items' as well (that's how I figured out the missing import), so I've set args starting from 1