Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pivx support #568

Merged
merged 2 commits into from
Aug 11, 2018
Merged

Pivx support #568

merged 2 commits into from
Aug 11, 2018

Conversation

erasmospunk
Copy link
Contributor

No description provided.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.2%) to 59.918% when pulling 7ccf672 on erasmospunk:pivx-support into 8d745f0 on kyuupichan:master.

@erasmospunk
Copy link
Contributor Author

After rebasing to the latest version it broke due to the new mempool code. Will re-upload with a fix.

@kyuupichan
Copy link
Owner

kyuupichan commented Aug 11, 2018

There's nothing here that's mempool dependent. Travis is flaky and falling arbitrarily recently. I think this was one of those?

@kyuupichan kyuupichan reopened this Aug 11, 2018
@kyuupichan kyuupichan merged commit 05c9e6b into kyuupichan:master Aug 11, 2018
@erasmospunk
Copy link
Contributor Author

No, the problem was the zerocoin transactions that have coinbase-like inputs.

@erasmospunk
Copy link
Contributor Author

Anyway, I will try to fix it in a new PR.

@kyuupichan
Copy link
Owner

OK - no tests failed, so if something is wrong I guess a new test is needed!

@erasmospunk erasmospunk deleted the pivx-support branch August 12, 2018 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants