Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename 'policies.kyverno.io/patches' to reflect actual functionality #1528

Closed
electrical opened this issue Feb 2, 2021 · 1 comment · Fixed by #2360
Closed

Rename 'policies.kyverno.io/patches' to reflect actual functionality #1528

electrical opened this issue Feb 2, 2021 · 1 comment · Fixed by #2360
Assignees
@anushkamittal20
Labels
end user This label is used to track the issue that is raised by the end user. enhancement New feature or request good first issue Good for newcomers mutation Issues pertaining to the mutate ability.
Milestone
Kyverno Release 1...

Comments

@electrical
Copy link

Is your feature request related to a problem? Please describe.
Following up from the Slack convo https://kubernetes.slack.com/archives/CLGR9BJU9/p1612304053201100
When you have a patching mutate policy, it adds the annotation policies.kyverno.io/patches containing the patches applied.
As soon as you have multiple separate policies patching the same resource, it only stores the last executed on in the annotation.

This caused a bit of confusion for myself and might confuse others in the future.

Describe the solution you'd like
It would be great to either just document it somewhere or, preferable, rename the annotation to reflect better what it actually stores.
Something like policies.kyverno.io/last-applied-patches.
@electrical electrical added the enhancement New feature or request label Feb 2, 2021
@realshuting realshuting added this to the Kyverno Release 1.3.3 milestone Feb 2, 2021
@realshuting realshuting added the good first issue Good for newcomers label Feb 4, 2021
@weastel weastel mentioned this issue May 2, 2021
Closed
@chipzoller chipzoller added the mutation Issues pertaining to the mutate ability. label Jul 15, 2021
@realshuting realshuting added the end user This label is used to track the issue that is raised by the end user. label Aug 4, 2021
@anushkamittal20
Copy link
Contributor

@realshuting I would like to work on this and resolve the issue.

@anushkamittal20 anushkamittal20 mentioned this issue Sep 4, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anushkamittal20 anushkamittal20

Labels
end user This label is used to track the issue that is raised by the end user. enhancement New feature or request good first issue Good for newcomers mutation Issues pertaining to the mutate ability.
Projects
None yet
Milestone
Kyverno Release 1.5.0
5 participants
@electrical @realshuting @chipzoller @anushkamittal20 @RinkiyaKeDad