Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample policies should have related CLI apply/test #1994

Closed
hans-d opened this issue Jun 10, 2021 · 7 comments
Closed

Sample policies should have related CLI apply/test #1994

hans-d opened this issue Jun 10, 2021 · 7 comments
Assignees
Labels
end user This label is used to track the issue that is raised by the end user. enhancement New feature or request

Comments

@hans-d
Copy link

hans-d commented Jun 10, 2021

Is your feature request related to a problem? Please describe.
See #1772 / #1909 / #1937. Having the sample policies run in verify/test/apply gives additional documentation on the working and also proves all are working with the current CLI.

Describe the solution you'd like
Each sample policy should have a test.yaml and additional yaml resources that proof the policy is working using the CLI.
New samples should be provided with such data before merging.

In addition:

  • regular/frequent tests should be run with the current CLI version to validate all is still working.
  • (newly) implemented features for policies should at minimal provide a sample policy (add to checklist)

Describe alternatives you've considered
none

@hans-d hans-d added the enhancement New feature or request label Jun 10, 2021
@realshuting
Copy link
Member

Thank you @hans-d for bringing this up, we'll address this issue along with #1821.

@chipzoller
Copy link
Member

Cross linking to discussion here: #2065

@realshuting
Copy link
Member

realshuting commented Jul 6, 2021

@viveksahu26 - since you are working on this issue, can you please comment so that I can assign it to you?

@viveksahu26
Copy link
Collaborator

/assign. Yes @realshuting , definitely assign me.

@realshuting realshuting added the end user This label is used to track the issue that is raised by the end user. label Aug 4, 2021
@viveksahu26
Copy link
Collaborator

Hey @realshuting, I have tried to cover all possible sample policies(both validate and mutate) which contains test.yaml files as well as resource.yaml files. So, can we close this issue now.
kyverno/policies#104
kyverno/policies#105

@viveksahu26
Copy link
Collaborator

And also now cli support test command for mutate policy.
#1821

@realshuting
Copy link
Member

Thank you @viveksahu26 🎉

@realshuting realshuting added this to the Kyverno Release 1.5.0 milestone Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
end user This label is used to track the issue that is raised by the end user. enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants