Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Kyverno ConfigMap name not consistent in Helm/Docs and install.yaml #2347

Closed
disposab1e opened this issue Aug 31, 2021 · 15 comments · Fixed by #2418 or #2927
Closed

[BUG] Kyverno ConfigMap name not consistent in Helm/Docs and install.yaml #2347

disposab1e opened this issue Aug 31, 2021 · 15 comments · Fixed by #2418 or #2927
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@disposab1e
Copy link

Kyverno: 1.4.2

In Helm/Docs the Kyverno ConfiMap is named kyverno. In install.yaml the same ConfigMap is named init-config.

ConfigMap:

apiVersion: v1
kind: ConfigMap
metadata:
  name: init-config
data: ....

Deployment:

apiVersion: apps/v1
kind: Deployment
  name: kyverno
spec:
  template:
    spec:
      containers:
      - args:
        - --filterK8sResources=[Event,*,*]........
        ........
        env:
        - name: INIT_CONFIG
          value: init-config

One more thing: The --filterK8sResources= in args are deprectaed. Intentionally in install.yaml left over?

@disposab1e disposab1e added the bug Something isn't working label Aug 31, 2021
@disposab1e disposab1e changed the title [BUG] Kyverno ConfigMap names not consistent in Helm/Docs and install.yaml [BUG] Kyverno ConfigMap name not consistent in Helm/Docs and install.yaml Aug 31, 2021
@realshuting realshuting added the good first issue Good for newcomers label Aug 31, 2021
@realshuting
Copy link
Member

Thanks @disposab1e, I added the label "good first issue" so that we can fast track the change.

@slayer321
Copy link
Contributor

Hey @realshuting, I did like to work on this issue .
where can I find install.yaml file?

@vyankyGH
Copy link
Contributor

vyankyGH commented Sep 1, 2021

Hey @realshuting, I did like to work on this issue .
where can I find install.yaml file?

https://github.com/kyverno/kyverno/blob/main/definitions/install.yaml

@slayer321
Copy link
Contributor

- args:
  - --filterK8sResources=[Event,*,*]........
  -  -v=2

in args do we also need to remove -v=2 and what does it signify?

@realshuting
Copy link
Member

@slayer321 - the default log level is 2, it does not change anything if you remove that flag.

@MnrGreg
Copy link
Contributor

MnrGreg commented Oct 21, 2021

There still seems to be misalignment here:

apiVersion: v1
data:
excludeGroupRole: system:serviceaccounts:kube-system,system:nodes,system:kube-scheduler
generateSuccessEvents: "false"
resourceFilters: '[Event,*,*][*,kube-system,*][*,kube-public,*][*,kube-node-lease,*][Node,*,*][APIService,*,*][TokenReview,*,*][SubjectAccessReview,*,*][SelfSubjectAccessReview,*,*][*,kyverno,*][Binding,*,*][ReplicaSet,*,*][ReportChangeRequest,*,*][ClusterReportChangeRequest,*,*][PolicyReport,*,*][ClusterPolicyReport,*,*]'
kind: ConfigMap
metadata:
labels:
app: kyverno
app.kubernetes.io/component: kyverno
app.kubernetes.io/instance: kyverno
app.kubernetes.io/managed-by: Kustomize
app.kubernetes.io/name: kyverno
app.kubernetes.io/part-of: kyverno
app.kubernetes.io/version: v1.5.0
name: kyverno

- name: INIT_CONFIG
value: init-config

@realshuting
Copy link
Member

cc @slayer321 @NoSkillGirl

@slayer321
Copy link
Contributor

Can someone explain what changes need to be done

@realshuting
Copy link
Member

@NoSkillGirl - can you help here?

@NoSkillGirl
Copy link
Contributor

NoSkillGirl commented Oct 27, 2021

@slayer321 - change the configmap name here

@realshuting - do we need to change the env variable name? or just changing the value is good enough.

@realshuting
Copy link
Member

@slayer321 - change the configmap name here

@realshuting - do we need to change the env variable name? or just changing the value is good enough.

Not sure, need to test and verify.

@NoSkillGirl
Copy link
Contributor

@slayer321 - please work on the changes and test if it works.

@slayer321
Copy link
Contributor

slayer321 commented Nov 3, 2021

Hey @NoSkillGirl, I tried changing both, name and value one by one and both are working fine .
so what should I do

do I just change the value?

......
  env:
    - name: INIT_CONFIG
       value: kyverno
......

or both?

......
  env:
    - name: INIT_CONFIG_NAME
       value: kyverno
......

and also this Uninstalling kyverno link is broken getting 404 error.
I think it should be

kubectl delete -f https://raw.githubusercontent.com/kyverno/kyverno/main/config/release/install.yaml

@NoSkillGirl
Copy link
Contributor

@realshuting - please suggest on the changes to be made.

and also this Uninstalling kyverno link is broken getting 404 error. I think it should be

kubectl delete -f https://raw.githubusercontent.com/kyverno/kyverno/main/config/release/install.yaml

@slayer321 - yes, we should change the following links:

@realshuting
Copy link
Member

Re-assigning to @zeborg as he's working on a related issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment