Feature/options in append or create #36

asteadyfactual · 2019-03-20T19:26:12Z

mistake, please ignore

Assuming that the LOGGER and CONFIG are set externally: ``` WebHDFS::Factual::LOGGER = LOGGER WebHDFS::Factual::CONFIG = CONFIG ```

Also rewrite NullLogger

It runs: * test-unit tests: already existed in webhdfs * rspec tests: migrated from nim

They're extremely noisy

Certain projects such as neutronic_exporter were using different names for the methods. Alias to them. The PRs for those projects which transition to this gem were also changed to use the names originally here. These aliases are merely added as a safeguard in case any are missed.

This seems to be more standard.

append doesn't allow a permission parameter so we only add it in the case of create. therefore we can't just pass an options hash into the append_or_create method itself; we'll have to make it more fine grained than that

Jorge Israel Peña added 30 commits February 15, 2019 11:37

Working replacement

377adff

Assuming that the LOGGER and CONFIG are set externally: ``` WebHDFS::Factual::LOGGER = LOGGER WebHDFS::Factual::CONFIG = CONFIG ```

Simplify method_missing definition

9a9d69e

Remove unused empty line

dad4aea

Don't capture exception when it's not used

b440af1

Thread api and default_namenode through clients

cb87777

Support setting logger

96e4425

Change NeutronicHelper exceptions to WebHDFS ones

578f6d6

Revert exception message capture change

8f35c56

Add rspec and webmock dev deps

7763978

Factor classes out to separate files

c3c6a38

Also rewrite NullLogger

Add Rake task for tests

d9b30c6

It runs: * test-unit tests: already existed in webhdfs * rspec tests: migrated from nim

Migrate api_connection tests

490646b

Migrate HDFS → InnerClient tests

a4f639f

Move env vars to spec_helper

56c0229

Explicitly add gssapi-factual dependency

42ba0c4

Fix test expectation

d213197

DRY obtaining a client

00c6d2a

Remove comment

f7a0b31

Migrate HDFSClient → Client tests

6d13a28

Keep logger name reference consistent

440cdbb

Remove task variables that are no longer needed

54dadc3

Fix remaining HDFS tests

d295e74

Migrate "behaves like fs interface" test

ca7c987

Migrate "behaves like fs implementation" tests

beb768f

Remove debug print statements

6cd2953

Fix existing webhdfs unit tests

01d44b9

Remove unused 'rr' dependency

6cb7408

Disable test_unit verbose and warning settings

155c4fe

They're extremely noisy

Add FIXME for returning false client

19643f4

Remove FIXMEs, change example inclusion

2aba7f3

Jorge Israel Peña and others added 28 commits February 15, 2019 11:37

Add docs on running tests

c21d199

Remove WebHDFS::Factual::InnerClient

11f3a1c

Add .rspec

1cfb7ce

Move RequestError to WebHDFS scope

526f666

Move many methods from Factual::Client to Client

b3da779

Remove Factual module

d73580e

Create WebHDFS::Simple

a807e94

Add rspec files

1dae7ee

Remove LOAD_PATH modification

43eb3f8

Make keytab_path_set? a singleton method

83a4129

Rename API_HOST env var to JMX_HOST

41d5b84

DRY environment setup

ce8774c

Remove NeutronicHelper error reminders

951f5de

Rename namenode to host

b26843e

Remove lingering puts

0b68373

Consolidate everything within the Client class

812129b

Reflect original HDFS wrapper call structure

e5073a3

Rename JMX_HOST → JMX, TEST_DIR → TEST_PATH

a081a99

Remove empty file

a75c0bf

Also remove require of simple.rb

3cc6c1f

Move legacy minitest tests to rspec

4944ce5

Reintroduce environment variable reading

4b28fdb

DRY up Client#simple attribute setting

998caa2

Clarify attribute setting wording

0a2c432

Remove redundant re-raising of FileNotFoundError

f22d2f2

Read keytab path from KEYTAB_PATH

ea4e3a8

This seems to be more standard.

add permission keyword arg to append or create

ec2390e

append doesn't allow a permission parameter so we only add it in the case of create. therefore we can't just pass an options hash into the append_or_create method itself; we'll have to make it more fine grained than that

asteadyfactual closed this Mar 20, 2019

benmayne deleted the feature/options-in-append-or-create branch August 16, 2021 13:53

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/options in append or create #36

Feature/options in append or create #36

asteadyfactual commented Mar 20, 2019 •

edited

Loading

Feature/options in append or create #36

Feature/options in append or create #36

Conversation

asteadyfactual commented Mar 20, 2019 • edited Loading

asteadyfactual commented Mar 20, 2019 •

edited

Loading