Add ngPipeArgs to ngPipe property
#1642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanmukhateja
requested changes
Feb 26, 2022
| expect(testsArray.map(index => { | ||
| const dataRow = rows[index]; | ||
|
|
||
| let pipeInstance = app.pipeCurrencyInstance; |
There was a problem hiding this comment.
This can be const as we don't re-declare pipeInstance.
|
|
||
| const NumberFromData = (instance.row(dataRow).data() as Person).id; | ||
| const NumberFromTable = $('td:nth-child(1)', dataRow).text(); | ||
| console.log(NumberFromData) |
There was a problem hiding this comment.
Forgot to remove these, I assume?
src/angular-datatables.directive.ts
Outdated
| @@ -106,13 +106,14 @@ export class DataTableDirective implements OnDestroy, OnInit { | |||
| const colsWithPipe = columns.filter(x => x.ngPipeInstance && !x.ngTemplateRef); | |||
| colsWithPipe.forEach(el => { | |||
| const pipe = el.ngPipeInstance; | |||
| const pipeArgs = el.ngPipeArgs ? el.ngPipeArgs : []; | |||
There was a problem hiding this comment.
This can be simplified to el.ngPipeArgs || [];
package.json
Outdated
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "angular-datatables", | |||
| "version": "13.0.1", | |||
| "version": "13.1.0", | |||
There was a problem hiding this comment.
Please revert this. I'll update the version at a later date.
| @@ -4,9 +4,9 @@ You need to install its dependencies: | |||
|
|
|||
| ```bash | |||
| # JS file | |||
| npm install datatables.net-colreorder --save | |||
There was a problem hiding this comment.
Can we move "responsive installation fix" to a different PR? We try not to mix unrelated code changes in single PR.
shanmukhateja
changed the title
ngPipe property
adrien-syrotnik
force-pushed
the
ng-pipe-args-responsive
branch
from
7eb468d
to
11eb31b
Compare
adrien-syrotnik
commented
Feb 27, 2022
l-lin
approved these changes
Mar 1, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I added the
ngPipeArgsoption with a test indemo/src/app/advanced/using-ng-pipe.component.spec.tsfile. I chose to take the data ID and convert it to currency because I didn't know how to import data.I also saw that the responsive installation was wrong, I decided to fix it.
Finally, this is my first pull request, if I did something wrong, don't hesitate to tell me.
Regards,
Adrien.