Skip to content

Commit

Permalink
[ReduceToolbarUpdatesForSameDocNavigations] Set feature default to false
Browse files Browse the repository at this point in the history
Forgot to set the default value to false/disabled when landing cl.

Bug: 1434461
Change-Id: I890bf3c0cdd1de71e4c3ffae81495799ef25ed04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/4480709
Commit-Queue: Peilin Wang <peilinwang@google.com>
Reviewed-by: Patrick Noland <pnoland@chromium.org>
Code-Coverage: Findit <findit-for-me@appspot.gserviceaccount.com>
Cr-Commit-Position: refs/heads/main@{#1135999}
  • Loading branch information
Peilin Wang authored and Chromium LUCI CQ committed Apr 26, 2023
1 parent b673bf0 commit f8b2699
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion chrome/browser/flags/android/chrome_feature_list.cc
Original file line number Diff line number Diff line change
Expand Up @@ -896,7 +896,7 @@ BASE_FEATURE(kRecordSuppressionMetrics,

BASE_FEATURE(kReduceToolbarUpdatesForSameDocNavigations,
"ReduceToolbarUpdatesForSameDocNavigations",
base::FEATURE_ENABLED_BY_DEFAULT);
base::FEATURE_DISABLED_BY_DEFAULT);

BASE_FEATURE(kReengagementNotification,
"ReengagementNotification",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ default boolean isOfflinePage(Tab tab) {
// using the flags below to short circuit all calls after the UrlBar has already been updated.
private static final MutableFlagWithSafeDefault sSameDocOptimizationsFlag =
new MutableFlagWithSafeDefault(
ChromeFeatureList.REDUCE_TOOLBAR_UPDATES_FOR_SAME_DOC_NAVIGATIONS, true);
ChromeFeatureList.REDUCE_TOOLBAR_UPDATES_FOR_SAME_DOC_NAVIGATIONS, false);
private boolean mIsInSameDocNav;
private boolean mIsSameDocNavFinished;
private boolean mAlreadyUpdatedUrlBarForSameDocNav;
Expand Down

0 comments on commit f8b2699

Please sign in to comment.